From c72dc86c194e788544560390e238eece2e4165e6 Mon Sep 17 00:00:00 2001 From: jistone Date: Wed, 23 Aug 2006 20:54:03 +0000 Subject: 2006-08-23 Josh Stone PR 3093 From Eugeniy Meshcheryakov : * main.cxx (main): Use setenv instead of putenv, since gcc 4.2 doesn't like assigning string constants to char*. Also use const char* for result from getenv. * tapsets.cxx (dwflpp::setup): Copy string constant into a local array, to fix gcc 4.2 warning. --- ChangeLog | 10 ++++++++++ main.cxx | 9 ++++----- tapsets.cxx | 3 ++- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 09a3814e..ce77eb5e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2006-08-23 Josh Stone + + PR 3093 + From Eugeniy Meshcheryakov : + * main.cxx (main): Use setenv instead of putenv, since gcc 4.2 + doesn't like assigning string constants to char*. Also use + const char* for result from getenv. + * tapsets.cxx (dwflpp::setup): Copy string constant into a + local array, to fix gcc 4.2 warning. + 2006-08-22 Josh Stone PR 3094 diff --git a/main.cxx b/main.cxx index 48759b98..0e584b5b 100644 --- a/main.cxx +++ b/main.cxx @@ -300,13 +300,12 @@ main (int argc, char * const argv []) int rc = 0; // override PATH and LC_ALL - char* path = "PATH=/bin:/sbin:/usr/bin:/usr/sbin"; - char* lc_all = "LC_ALL=C"; - rc = putenv (path) || putenv (lc_all); + const char *path = "/bin:/sbin:/usr/bin:/usr/sbin"; + rc = setenv("PATH", path, 1) || setenv("LC_ALL", "C", 1); if (rc) { const char* e = strerror (errno); - cerr << "setenv (\"" << path << "\" + \"" << lc_all << "\"): " + cerr << "setenv (\"PATH=" << path << "\" + \"LC_ALL=C\"): " << e << endl; } @@ -316,7 +315,7 @@ main (int argc, char * const argv []) // Create a temporary directory to build within. // Be careful with this, as "s.tmpdir" is "rm -rf"'d at the end. { - char* tmpdir_env = getenv("TMPDIR"); + const char* tmpdir_env = getenv("TMPDIR"); if (! tmpdir_env) tmpdir_env = "/tmp"; diff --git a/tapsets.cxx b/tapsets.cxx index 6d843d5b..2aa5e1b7 100644 --- a/tapsets.cxx +++ b/tapsets.cxx @@ -763,7 +763,8 @@ dwflpp void setup(bool kernel) { // XXX: this is where the session -R parameter could come in - static char* debuginfo_path = "-:.debug:/usr/lib/debug"; + static char debuginfo_path_arr[] = "-:.debug:/usr/lib/debug"; + static char *debuginfo_path = debuginfo_path_arr; static const Dwfl_Callbacks proc_callbacks = { -- cgit