From 822a1ad1816dfc315197ddc6d70e45a56eae5051 Mon Sep 17 00:00:00 2001 From: fche Date: Tue, 27 Feb 2007 20:58:40 +0000 Subject: 2007-02-27 Frank Ch. Eigler * tapsets.cxx (dwflpp setup): Print "missing kernel debuginfo" message consistently for, er, missing kernel debuginfo. (query_kernel_exists): Zapped. --- ChangeLog | 6 ++++++ tapsets.cxx | 23 +---------------------- 2 files changed, 7 insertions(+), 22 deletions(-) diff --git a/ChangeLog b/ChangeLog index fc8c56ca..c42d1f41 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2007-02-27 Frank Ch. Eigler + + * tapsets.cxx (dwflpp setup): Print "missing kernel debuginfo" + message consistently for, er, missing kernel debuginfo. + (query_kernel_exists): Zapped. + 2007-02-27 David Smith * systemtap.spec.in: Fedora Packaging Guidelines updates. Updated diff --git a/tapsets.cxx b/tapsets.cxx index 55e64942..a156ca7f 100644 --- a/tapsets.cxx +++ b/tapsets.cxx @@ -778,7 +778,7 @@ struct dwflpp throw semantic_error ("cannot open dwfl"); dwfl_report_begin (dwfl); - dwfl_assert ("dwfl_linux_kernel_report_offline", + dwfl_assert ("missing kernel debuginfo", dwfl_linux_kernel_report_offline (dwfl, sess.kernel_release.c_str(), @@ -2816,20 +2816,6 @@ query_cu (Dwarf_Die * cudie, void * arg) } -static int -query_kernel_exists (Dwfl_Module *mod __attribute__ ((unused)), - void **userdata __attribute__ ((unused)), - const char *name, - Dwarf_Addr base __attribute__ ((unused)), - void *arg) -{ - int *flagp = (int *) arg; - if (TOK_KERNEL == name) - *flagp = 1; - return DWARF_CB_OK; -} - - static int query_kernel_module (Dwfl_Module *mod, void **userdata __attribute__ ((unused)), @@ -3868,13 +3854,6 @@ dwarf_builder::build(systemtap_session & sess, (q.has_kernel && q.has_inline_str) || (q.has_kernel && q.has_statement_str) || (q.has_module)); - if (q.has_kernel) - { - int flag = 0; - dw->iterate_over_modules(&query_kernel_exists, &flag); - if (! flag) - throw semantic_error ("cannot find kernel debuginfo"); - } dw->iterate_over_modules(&query_module, &q); } -- cgit