diff options
| author | Josh Stone <jistone@redhat.com> | 2009-08-26 17:05:29 -0700 |
|---|---|---|
| committer | Josh Stone <jistone@redhat.com> | 2009-08-26 17:20:00 -0700 |
| commit | 8a9a609f15c3088bcaaf9728393662372f91ab62 (patch) | |
| tree | 21b0135f41f99536317a829c97f005e2ccb8e9a8 /staptree.cxx | |
| parent | b13d5a188321fc6856cf379a74b3004ce094a3af (diff) | |
| download | systemtap-steved-8a9a609f15c3088bcaaf9728393662372f91ab62.tar.gz systemtap-steved-8a9a609f15c3088bcaaf9728393662372f91ab62.tar.xz systemtap-steved-8a9a609f15c3088bcaaf9728393662372f91ab62.zip | |
Cleanup some deref handling in the task tapset
Some of this is just cosmetic, but there is one big takeaway: there's a
error-goto between kread calls and the CATCH_DEREF_FAULT. You must not
allow this to bypass any resource management, like unlocking a resource
that you grabbed!
* tapset/task.stp (pid2task): No derefs, so remove the CATCH.
(task_gid, task_egid, task_uid, task_euid): Move the CATCH within the
#ifdef branch that actually needs it.
(task_open_file_handles, task_max_file_handles): Ensure that we always
call rcu_read_unlock if we locked it!
Diffstat (limited to 'staptree.cxx')
0 files changed, 0 insertions, 0 deletions