From dd09bbb2578bd9f82afd7fc4d4fcc3a5659731d3 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn@redhat.com>
Date: Sat, 11 Oct 2014 13:10:18 +0200
Subject: GPO: Fail if we cannot retrieve gpo from cache.

The variable value could be used uninitialized.

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
---
 src/providers/ad/ad_gpo.c | 6 ++++++
 1 file changed, 6 insertions(+)

(limited to 'src')

diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
index d581db8f..2d8ba82d 100644
--- a/src/providers/ad/ad_gpo.c
+++ b/src/providers/ad/ad_gpo.c
@@ -1358,6 +1358,12 @@ parse_policy_setting_value(TALLOC_CTX *mem_ctx,
     char **sids_list = NULL;
 
     ret = sysdb_gpo_get_gpo_result_setting(mem_ctx, domain, key, &value);
+    if (ret != EOK) {
+        DEBUG(SSSDBG_OP_FAILURE,
+              "Cannot retrieve settings from sysdb for key: '%s' [%d][%s].\n",
+              key, ret, sss_strerror(ret));
+        goto done;
+    }
 
     if (value == NULL) {
         DEBUG(SSSDBG_TRACE_FUNC,
-- 
cgit