From f8e337540d280f944098cd4dd7d670e2f7166b54 Mon Sep 17 00:00:00 2001 From: Petr Cech Date: Mon, 5 Oct 2015 10:12:36 -0400 Subject: REFACTOR: umask(077) --> umask(SSS_DFL_X_UMASK) There are many calls of umask function with 077 argument. This patch add new constant SSS_DFL_X_UMASK which stands fot 077. So all occurences of umask(077) are replaced by constant SSS_DFL_X_UMASK. Resolves: https://fedorahosted.org/sssd/ticket/2424 Reviewed-by: Jakub Hrozek --- src/tests/check_and_open-tests.c | 2 +- src/tests/debug-tests.c | 4 ++-- src/tests/util-tests.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/tests') diff --git a/src/tests/check_and_open-tests.c b/src/tests/check_and_open-tests.c index e5981c85..25aee1fb 100644 --- a/src/tests/check_and_open-tests.c +++ b/src/tests/check_and_open-tests.c @@ -48,7 +48,7 @@ void setup_check_and_open(void) filename = strdup(FILENAME_TEMPLATE); fail_unless(filename != NULL, "strdup failed"); - old_umask = umask(077); + old_umask = umask(SSS_DFL_X_UMASK); ret = mkstemp(filename); umask(old_umask); fail_unless(ret != -1, "mkstemp failed [%d][%s]", errno, strerror(errno)); diff --git a/src/tests/debug-tests.c b/src/tests/debug-tests.c index 067209b1..8d927401 100644 --- a/src/tests/debug-tests.c +++ b/src/tests/debug-tests.c @@ -133,7 +133,7 @@ int test_helper_debug_check_message(int level) strncpy(filename, "sssd_debug_tests.XXXXXX", 24); - old_umask = umask(077); + old_umask = umask(SSS_DFL_X_UMASK); fd = mkstemp(filename); umask(old_umask); if (fd == -1) { @@ -273,7 +273,7 @@ int test_helper_debug_is_empty_message(int level) strncpy(filename, "sssd_debug_tests.XXXXXX", 24); - old_umask = umask(077); + old_umask = umask(SSS_DFL_X_UMASK); fd = mkstemp(filename); umask(old_umask); if (fd == -1) { diff --git a/src/tests/util-tests.c b/src/tests/util-tests.c index bfdf0780..88c6727d 100644 --- a/src/tests/util-tests.c +++ b/src/tests/util-tests.c @@ -593,7 +593,7 @@ void setup_atomicio(void) fail_unless(filename != NULL, "strdup failed"); atio_fd = -1; - old_umask = umask(077); + old_umask = umask(SSS_DFL_X_UMASK); ret = mkstemp(filename); umask(old_umask); fail_unless(ret != -1, "mkstemp failed [%d][%s]", errno, strerror(errno)); -- cgit