From cfaa16fe871f10f5bba0a55beb39e8223dbdf001 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 26 Feb 2014 09:45:46 +0100 Subject: KRB5: Fix condition for empty string MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reported by: cppcheck Finding the same expression on both sides of an operator || is suspicious and might indicate a cut and paste or logic error. Resolves: https://fedorahosted.org/sssd/ticket/2258 Reviewed-by: Michal Žídek --- src/providers/krb5/krb5_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/providers/krb5/krb5_common.c b/src/providers/krb5/krb5_common.c index 3d0fc0bf..bf7b1f0e 100644 --- a/src/providers/krb5/krb5_common.c +++ b/src/providers/krb5/krb5_common.c @@ -422,7 +422,7 @@ errno_t write_krb5info_file(const char *realm, const char *server, mode_t old_umask; if (realm == NULL || *realm == '\0' || server == NULL || *server == '\0' || - service == NULL || service == '\0') { + service == NULL || *service == '\0') { DEBUG(SSSDBG_CRIT_FAILURE, "Missing or empty realm, server or service.\n"); return EINVAL; -- cgit