From 7c3cc1ee2914bc7b38a992c1af254fc76af5a1ad Mon Sep 17 00:00:00 2001
From: Pavel Reichl <preichl@redhat.com>
Date: Thu, 23 Jul 2015 04:40:03 -0400
Subject: DYNDNS: Don't use server cmd in nsupdate by default

nsupdate command `server` should not be used for the first attempt
to udpate DNS. It should be used only in subsequent attempts after the
first attempt failed.

Resolves:
https://fedorahosted.org/sssd/ticket/2495

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
---
 src/man/sssd-ad.5.xml            | 6 +++++-
 src/man/sssd-ipa.5.xml           | 5 +++++
 src/providers/ldap/sdap_dyndns.c | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml
index 7ccd2979..127e9658 100644
--- a/src/man/sssd-ad.5.xml
+++ b/src/man/sssd-ad.5.xml
@@ -825,13 +825,17 @@ ad_gpo_map_deny = +my_pam_service
                             where the DNS server is different from the identity
                             server.
                         </para>
+                        <para>
+                            Please note that this option will be only used in
+                            fallback attempt when previous attempt using
+                            autodetected settings failed.
+                        </para>
                         <para>
                             Default: None (let nsupdate choose the server)
                         </para>
                     </listitem>
                 </varlistentry>
 
-
                 <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" href="include/override_homedir.xml" />
                 <xi:include xmlns:xi="http://www.w3.org/2001/XInclude" href="include/homedir_substring.xml" />
 
diff --git a/src/man/sssd-ipa.5.xml b/src/man/sssd-ipa.5.xml
index 871c4160..be390d58 100644
--- a/src/man/sssd-ipa.5.xml
+++ b/src/man/sssd-ipa.5.xml
@@ -275,6 +275,11 @@
                             where the DNS server is different from the identity
                             server.
                         </para>
+                        <para>
+                            Please note that this option will be only used in
+                            fallback attempt when previous attempt using
+                            autodetected settings failed.
+                        </para>
                         <para>
                             Default: None (let nsupdate choose the server)
                         </para>
diff --git a/src/providers/ldap/sdap_dyndns.c b/src/providers/ldap/sdap_dyndns.c
index 01f4f172..0f0e63ee 100644
--- a/src/providers/ldap/sdap_dyndns.c
+++ b/src/providers/ldap/sdap_dyndns.c
@@ -112,10 +112,10 @@ sdap_dyndns_update_send(TALLOC_CTX *mem_ctx,
     state->auth_type = auth_type;
     state->pass_num = 0;
 
+    /* fallback servername is overriden by user option */
     conf_servername = dp_opt_get_string(opts, DP_OPT_DYNDNS_SERVER);
     if (conf_servername != NULL) {
         state->servername = conf_servername;
-        state->use_server_with_nsupdate = true;
     }
 
     if (ifname) {
-- 
cgit