sssd.git/src/util, branch reviews

failover: Protect against empty host names

2013-01-02T16:44:09+00:00

Added new parameter to split_on_separator that allows to skip
empty values.

The whole function was rewritten. Unit test case was added to
check the new implementation.

https://fedorahosted.org/sssd/ticket/1484

Carefully check records when forcibly invalidating

2012-12-20T18:55:02+00:00

We should never try to invalidate an already invalid record as
internal pointers will not be consistent. Carefully test that the
record really is valid when we are fishing for free space, and
properly invalidate records or return a fatal error if something
goes wrong.
In order to make the code more robust always invalidate the whole
data space on initialization by setting all bits to 1, and make sure
to invalidate the whole last allocated slot by converting rec->len to
the number of slots instead of just the space used.

Free resources if fileno failed

2012-12-20T17:12:18+00:00

select_principal_from_keytab() do wildcard lookups after specific ones

2012-12-18T18:04:06+00:00

Currently the wildcard lookup '*$' is done before the one for
host/our.hostname@REALM. This means we would ignore a more specific
match in favour of an unspecific match with a principal which is only
used in a AD environment.

I think this is wrong an wildcards should only be used is all specific
lookups fail.

select_principal_from_keytab() look for plain input as well

2012-12-18T18:04:06+00:00

Currently in select_principal_from_keytab() all kind of different
versions of the host principal are looked up in the keytab except for
the plain name the ldap_sasl_authid option. With this patch the plain
name is looked up first.

Set cloexec flag for log files

2012-12-18T10:34:11+00:00

https://fedorahosted.org/sssd/ticket/1708

The services kept the fd to /var/log/sssd/sssd.log open. I don't think
there's any point in keeping the logfiles open after exec-ing for the
child, so I set the CLOEXEC flag.

Avoid const warnings when deallocating memory

2012-11-28T12:36:12+00:00

In some case we allocate and assign data to a const pointer.
When we then try to free it we would get a const warning because talloc_free
accepts a void, not a const void pointer. Use discard_const to avoid the
warning, it is safe in this case.

Revert "Avoid accessing half-deallocated memory when using talloc_zfree macro."

2012-11-28T12:36:12+00:00

This reverts commit ff57c6aeb80a52b1f52bd1dac9308a69dc7a4774.

This commit doesn't really make sense, we are never accessing freed
memory as all we are dealing with is a pointer which is never itsef
part of the memory we are freeing (if it were, it would be an error
in the caller and we shouldn't mask it in this macro).

debug: print fatal and critical errors if debug level is unresolved

2012-11-26T19:58:41+00:00

If global variable debug_level has value SSSDBG_UNRESOLVED, we should
print at least fatal and critical errors.

https://fedorahosted.org/sssd/ticket/1345

Handle compiling FQDN regular expression with old pcre gracefully

2012-11-22T16:11:26+00:00

https://fedorahosted.org/sssd/ticket/1661