sssd.git/src/providers, branch my-master

Cleanup error message handling for krb5 child

2013-01-04T19:40:54+00:00

Use the new internal SSSD errors, to simplify error handling.
Instad of having up to 3 different errors to care about (system, krb5 and
pam_status), collapse all error reporting into one error type mapped on
errno_t.

The returned error can contain either SSSD internal errors, kerberos errors
or system errors, they all use differen number spaces so there is no overlap
and tey can be safely merged.

This means the errors bein sent from the child to the parent is not a pam
status error message anymore. The parent properly deals with that.

Also not that this patch removes returning SSS_PAM_SYSTEM_INFO from the
krb5_child for kerberos errors as all it was doing was simply to make the
parent emit the same debug log already emitted by the child, and the code
is simpler if we do not do that.

Refactor krb5 child

2013-01-04T19:38:36+00:00

The aim of this refactoring is to make the code readable and understandable.
This code has grown organically over time and has becomed confused and
baroque enough that understanding it's very simple flow had become very
complex for the uninitiated. Complex flows easily hide nasty bugs.

Improvements:
- Remove dead/unused data storage
- Fix and simplify talloc hierarchy, use a memory context (kr) for the
whole code and allocate kr->pd where it is filled up.
- Rename some functions to create a better name space (easier for
searching fucntions across the tree)
- Streamline setup function, by spliting out fast setup in a subroutine.
- Avoid confusing indirection in executng actual functions by not
using the krb5_req child_req member.
- Make main() flow s now simmetric, send abck data from the main function
instead of delegating a reply to every inner function that implements a
command.

Now the flow is evident from the main function:
1. read request
2. setup data
3. execute command
4. send reply back

krb5_child style fix

2013-01-04T19:38:36+00:00

Use the standard 'done' label for exceptions.

LDAP: initialize refresh function handler

2013-01-04T15:34:23+00:00

let krb5_backup_kpasswd failover work

2013-01-02T16:59:02+00:00

https://fedorahosted.org/sssd/ticket/1735

failover: Protect against empty host names

2013-01-02T16:44:09+00:00

Added new parameter to split_on_separator that allows to skip
empty values.

The whole function was rewritten. Unit test case was added to
check the new implementation.

https://fedorahosted.org/sssd/ticket/1484

set ret to EOK after for loop in sdap_sudo_purge_sudoers

2013-01-02T16:39:44+00:00

If we are unable to delete some rule from cache we print a debug
message and ignore the error. Thus we should set ret to EOK after
the for loop otherwise we return whether the last rule was deleted
successfully or not.

This also removes compilation warning that ret may be used
uninitialized (when we don't go inside the loop at all).

krb5 tgt renewal: fix usage of ldb_dn_get_component_val()

2012-12-20T18:41:11+00:00

For some reason I was under the impression that the DN components are
counted backwards in libldb. This patch corrects this.

Add default section to switch statement

2012-12-19T17:42:58+00:00

switch statements should always have a default section. In this
particular case gcc gave a "'send_fn' may be used uninitialized in this
function" warning.

DP: invalidate all cached maps if a request for auto.master comes in

2012-12-18T16:25:34+00:00

If the Data Provider receives a request for the auto.master map, it
passes on a flag to let the actual provider let know he should
invalidate the existing maps