From 5758360a2e970a48a9c64e91b3a14a8a65825be0 Mon Sep 17 00:00:00 2001 From: Julia Varlamova Date: Wed, 17 Jul 2013 16:02:51 +0400 Subject: Raise ValueError if sort_dir is unknown Raise ValueError in case of KeyError, when sort_dir is not 'asc' or 'desc'. ValueError while adding pagination has never been raised before, because if sort direction was incorrect, KeyError has been raised while adding sorting. Change-Id: Ia0366dbdf38557c4e6a9307fb27c77fd1c1873c3 --- tests/unit/db/sqlalchemy/test_utils.py | 2 -- 1 file changed, 2 deletions(-) (limited to 'tests') diff --git a/tests/unit/db/sqlalchemy/test_utils.py b/tests/unit/db/sqlalchemy/test_utils.py index 12f92ef..15a1e25 100644 --- a/tests/unit/db/sqlalchemy/test_utils.py +++ b/tests/unit/db/sqlalchemy/test_utils.py @@ -22,7 +22,6 @@ from sqlalchemy import MetaData, Table, Column from sqlalchemy.engine import reflection from sqlalchemy.sql import select from sqlalchemy.types import UserDefinedType, NullType -import testtools from openstack.common.db.sqlalchemy import utils from openstack.common import exception @@ -139,7 +138,6 @@ class TestPaginateQuery(testutils.BaseTestCase): marker=self.marker, sort_dirs=['asc', 'desc']) - @testtools.skip('The bug is not fixed: ValueError never raises') def test_paginate_query_value_error(self): sqlalchemy.asc('user').AndReturn('asc_1') self.query.order_by('asc_1').AndReturn(self.query) -- cgit