summaryrefslogtreecommitdiffstats
path: root/HACKING.rst
Commit message (Collapse)AuthorAgeFilesLines
* Do not raise NEW exceptionsSergey Vilgelm2013-06-251-0/+10
| | | | | | | | | | | | | | | | | | | | | | Raising NEW exception is bad practice, because we lose TraceBack. So all places like: except SomeException as e: raise e should be replaced by except SomeException: raise If we are doing some other actions before reraising we should store information about exception then do all actions and then reraise it. This is caused by eventlet bug. It lost information about exception if it switch threads. fixes bug 1191730 Change-Id: I7bce659591c4c3e4bc41e12d7d8390128c30e2e4
* Update HACKING.rst per recent changesZhongyue Luo2013-02-041-3/+10
| | | | | | | | | | | | | Added "is not" usage with examples Fixed "not in" usage description https://review.openstack.org/#/c/20576/ and https://review.openstack.org/#/c/20879/ Fixes a previous "not X in Y" grep corner case Change-Id: I92ae642887de734a8562a528003d8092f5ff27d4
* Fixes 'not in' operator usageZhongyue Luo2013-01-311-0/+12
| | | | Change-Id: Ibac9853fc72e2452fa5e2b3a493bd03523faabfb
* Use testtools as test base class.Monty Taylor2013-01-241-1/+1
| | | | | | | | | | | | | On the path to testr migration, we need to replace the unittest base classes with testtools. Replace tearDown with addCleanup, addCleanup is more resilient than tearDown. The fixtures library has excellent support for managing and cleaning tempfiles. Use it. Replace skip_ with testtools.skipTest Part of blueprint grizzly-testtools. Change-Id: I45e11bbb1ff9b31f3278d3b016737dcb7850cd98
* Fix ordering in HACKING.rstJoe Gordon2012-04-261-1/+1
| | | | | | | | | | Already fixed in nova. Switched: from nova.endpoint import cloud import nova.flags Change-Id: I5d4f64d0710c8bb12031c3960401f6d6d2a67843
* Added a universal style-guide for all OS projects.Andrew Bogott2012-03-221-0/+257
Pursuant to a recent mailing list discussion, this file contains the union of all style recommendations from varions openstack projects. The file will be removed from individual projects. Change-Id: I79c118ff749d7c89d7d88302279ec8cb1530868d