summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Reduce test_zmq's reponse timeout.Eric Windisch2012-08-011-0/+1
| |/ |/| | | | | | | | | | | | | | | | | | | | | The rpc response timeout in Nova's fake_flags.py was 5 seconds. This was lost in the transition to openstack-common, is no longer set globally. As in test_kombu.py, this should be set in test_zmq.py The default value is much higher than it needs to be for the purposes of testing. A lower value fails faster, resulting in faster tests in the event of failures. Change-Id: I106919d36acd19b702be85e453e949495db70ea9
* | Merge "Remove code to clear basicConfig root log handlers"Jenkins2012-07-311-11/+0
|\ \
| * | Remove code to clear basicConfig root log handlersDan Prince2012-07-311-11/+0
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes some old Nova specific code to clear out the log handlers from Nova's logging basicConfig. This code is arguably Nova specific and doesn't really belong in openstack-common's generic logging configuration. Additionally, This code was actually removing the root logger used by some command line tools and binaries and hiding log messages that should have otherwise gone to the console. Fixes LP Bug #1029577. Change-Id: Ia3531bea41a2226798f3910803a4323f1984e767
* | Merge "Copy LoopingCall from nova for service.py"Jenkins2012-07-312-0/+140
|\ \
| * | Copy LoopingCall from nova for service.pyAngus Salkeld2012-07-312-0/+140
| |/ | | | | | | | | Change-Id: Ib6683324f92345c17cfd7234d08070b48ffb4d3e Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
* | Merge "Remove unnecessary register_opts from test_zmq"Jenkins2012-07-311-2/+0
|\ \ | |/ |/|
| * Remove unnecessary register_opts from test_zmqEric Windisch2012-07-251-2/+0
| | | | | | | | | | | | | | The calls to register_opts are no longer required, and are no longer called from the tests of other rpc mechanisms. Change-Id: I40fe63d43aad8fcf37d5332a1aa05e2b3068f01a
* | Merge "don't throw exceptions if %(color)s tag is used"Jenkins2012-07-302-2/+60
|\ \
| * | don't throw exceptions if %(color)s tag is usedSean Dague2012-07-272-2/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixed bug #1030078 If the log format strings include the %(color)s key in them and you enable file logging, your log files won't work, and instead you'll see exceptions on the console as the default python log handler doesn't support that keyword. This approach stubs out the extra keywords to be empty strings to avoid the KeyError. Tests are also added to demonstrate the KeyError as defined behavior, and test that color codes can be passed. Change-Id: Ia5dbaee9c530e243e2121667c8a54e6f9d66e1e7
* | | Merge "Use BaseTestCase for all tests which override config"Jenkins2012-07-304-38/+19
|\ \ \
| * | | Use BaseTestCase for all tests which override configMark McLoughlin2012-07-204-38/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug #1027120 We already have nice helper methods for overriding config and cleaning up the overrides, so let's use them. Change-Id: Ibd501743d1c4ec21cb2b0d22382cb681ee5768ed
* | | | fix the qpid_heartbeat option so that it's effectivePádraig Brady2012-07-301-1/+1
| |/ / |/| | | | | | | | | | | | | | | | | | | | The 'hearbeat' typo caused this setting to be ineffective. This bug has been present since the initial nova qpid implementation. Fixes bug: 1030430 Change-Id: Ibb9d7484b9d11a6904cc9e2a8dde6d9164ee05b1
* | | Remove unused importsJoe Gordon2012-07-264-4/+0
| | | | | | | | | | | | Change-Id: Ia2900e50263950ba40ba86e685640cacaa2137a7
* | | Modifies _is_opt_registered fcn to check for duplicate optsGiampaolo Lauria2012-07-242-7/+6
| |/ |/| | | | | | | | | | | | | | | | | This change fixes bug 999307 Currently, the check for duplicate options is done by checking whether they are the same object. The proposed fix is to check whether all the object fields have the same value. Change-Id: I2b72d630a0c8821df1d81e25d316d8d9195be492
* | Merge changes I536e1ca0,Ifb878368,Ie1d71b85Jenkins2012-07-232-12/+25
|\ \ | | | | | | | | | | | | | | | | | | * changes: Add missing convert_instances arg. Track to_primitive() depth after iteritems(). Update iteritems test case to actually test iteritems.
| * | Add missing convert_instances arg.Russell Bryant2012-07-181-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | When calling jsonutils.to_primitive() recursively, the convert_instances argument should be passed along. This change fixes one place where it was not. Change-Id: I536e1ca05bb4e613fba71298797879587e8b4b00
| * | Track to_primitive() depth after iteritems().Russell Bryant2012-07-182-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change jsonutils.to_primitive() to increase the recursion depth counter when calling to_primitive() on the result of iteritems() from the current element. Previously, the only time the counter was increased was when converting the __dict__ from an object. The iteritems() case risks cycles, as well. I hit a problem with this when trying to call to_primitive on an instance of nova.db.sqlalchemy.models.Instance. An Instance includes a reference to InstanceInfoCache, which has a reference back to the Instance. Without this change, to_primitive() would raise an exception for an Instance due to excessive recursion. Related to nova blueprint no-db-messaging. Change-Id: Ifb878368d97e92ab6c361a4dd5f5ab2e68fc16e2
| * | Update iteritems test case to actually test iteritems.Russell Bryant2012-07-181-11/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch updates the jsonutils.to_primitive() test case for when an object has an iteritems() method. The previous implementation was mostly a copy of another test and didn't actually test calling iteritems() at all. Now it does. This is used by NovaBase in nova.db.sqlalchemy.models. Related to nova blueprint no-db-messaging. Change-Id: Ie1d71b859219392ab35b82dd3c7932b30e759c89
* | | Merge "Make test_zmq bind/send to 127.0.0.1"Jenkins2012-07-231-0/+3
|\ \ \
| * | | Make test_zmq bind/send to 127.0.0.1Eric Windisch2012-07-201-0/+3
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By default, the impl_zmq driver binds to '*' (0.0.0.0); For the purposes of testing, we only need to bind to 127.0.0.1. Binding to all interfaces could be potentially dangerous, may simply not work in some environments, etc. In particular, we do not want our Jenkins slaves to be listening on public interfaces. rpc_zmq_host is set to 127.0.0.1 as well, which avoids hostname resolution. Normally, rpc_zmq_host is set to socket.hostname, which normally should resolve to localhost, but we do not want to test that here. Change-Id: I1224799bb399ceaf79088dd622be4b6823f29a41
* / | Enable fanout_cast and fanout_cast_to_server to provide topicGary Kotton2012-07-231-4/+8
|/ / | | | | | | | | | | | | The code would make use of the self.topic instead of allowing the user to define the topic. Change-Id: Ibdd4fab6dd019d223c3256d70f123829939056d2
* | Merge "Add test-options from Nova /w pyzmq"Jenkins2012-07-202-0/+7
|\ \ | |/ |/|
| * Add test-options from Nova /w pyzmqEric Windisch2012-07-172-0/+7
| | | | | | | | Change-Id: Ieebefee89483e5abbcefe1bb9059d89c91dc04df
* | fix bug lp:1019348,update openstack-common to support pep8 1.3.Yaguang Tang2012-07-1816-109/+111
|/ | | | | | also,this patch turns off pep8 E125 check. Change-Id: I22d2a94d89530586d614af39af17ae542c5e0cbf
* cfg: allow empty config valuesMark McLoughlin2012-07-172-1/+7
| | | | | | | | | | | | | | Fixes bug #1025522 Commit 83044a7 caused this to stop working in Quantum: api_extensions_path = and could only be worked around with: api_extensions_path = "" Change-Id: I8c1a57225a2c135e6baf567b8e71d61e974da4e2
* Don't switch to list_notifier unless necessary.Andrew Bogott2012-07-152-17/+33
| | | | | | | | | | | Some notification tests depend on a different, single notifier being used. So, don't switch to the list notifier just because we loaded this class; only switch if an actual plugin needs it. Also: improved the test that makes sure all this notifier-switching doesn't break the notifier that was present in the first place. Change-Id: I170477bccb3ad9505fe6dbfbc214f77c09f6862f
* Use strtime() in to_primitive() for datetime objs.Russell Bryant2012-07-163-4/+12
| | | | | | | | | | | This patch updates jsonutils.to_primitive() to use timeutils.strtime() to convert a datimetime object to a string instead of just using str(). This ensures that we can easily convert the string back to a datetime using timeutils.parse_strtime(). Required for the nova blueprint no-db-messaging. Change-Id: I725b333695930e12e2832378102514326fec639c
* Merge "Add additional usage info on rpc_zmq_host flag"Jenkins2012-07-161-1/+2
|\
| * Add additional usage info on rpc_zmq_host flagEric Windisch2012-07-131-1/+2
| | | | | | | | Change-Id: I8f1f3b42de7253c993e2afa44ed1c0ad4dbbb74f
* | Merge "Restore register_opts on impl_zmq module load"Jenkins2012-07-161-0/+3
|\ \
| * | Restore register_opts on impl_zmq module loadEric Windisch2012-07-131-0/+3
| | | | | | | | | | | | Change-Id: I6acdf1445e1f03246476292b38d7c52a29934af1
* | | Merge "Minor pep8 cleanup in rpc."Jenkins2012-07-151-1/+1
|\ \ \
| * | | Minor pep8 cleanup in rpc.Andrew Bogott2012-07-082-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Removed a space, reordered an import. Change-Id: I418d1f7c6a5a3b8ef231c88b4ef28114ca0eb7cd
* | | | Merge "pep8 cleanup in the plugin code"Jenkins2012-07-152-2/+3
|\ \ \ \ | |_|_|/ |/| | |
| * | | pep8 cleanup in the plugin codeAndrew Bogott2012-07-082-2/+3
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | The nova hacking test turned up one alphabetization error that I missed previously. Also, our path-altering process caused one line to exceed 80 characters when copied into nova; that line is shorter now. Change-Id: Ia3acfc25ecc5ba388526766dae3ed03792e906e3
* | / Fix typo made in 372d11e990Eric Windisch2012-07-131-1/+1
| |/ |/| | | | | Change-Id: Iba232257595bb3084052a21a560f2f5551b5f1eb
* | Merge "Exclude .egg files from pep8 checks"Jenkins2012-07-131-1/+1
|\ \
| * | Exclude .egg files from pep8 checksEric Windisch2012-07-131-1/+1
| | | | | | | | | | | | Change-Id: I0f403cfa8edec3795f65cf270a9cb2ad0a05d4f5
* | | Fix import order of gettextutils in amqp.pyEric Windisch2012-07-131-1/+1
|/ / | | | | | | Change-Id: I53ca8308fb61c53274ca1e3d801f22c9b65d41aa
* | Add more rpc version docs.Russell Bryant2012-07-131-0/+39
| | | | | | | | | | | | | | This patch adds some additional documentation, including some examples, on making changes to versioned RPC APIs. Change-Id: I5f40b11e07538f36d0f1299f7e822b408bf8e96a
* | Merge "Add SKIP_GENERATE_AUTHORS option to setup.py"Jenkins2012-07-131-11/+15
|\ \
| * | Add SKIP_GENERATE_AUTHORS option to setup.pyDan Prince2012-07-131-11/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updates the generate_authors function in setup.py so that it will skip generation of the authors file if the SKIP_GENERATE_AUTHORS env variable is set. Authors doesn't currently take that long to generate but having the option to explicitly skip it (regardless of whether .git is there) seems like a good addition. Change-Id: Ie18064d2450cecc86f18d0b10e1ce473253d1a51
* | | Add SKIP_WRITE_GIT_CHANGELOG option to setup.pyDan Prince2012-07-131-6/+10
|/ / | | | | | | | | | | | | | | | | | | | | | | Updates the write_git_changelog function in setup.py so that it will skip changelog generation if the SKIP_WRITE_GIT_CHANGELOG env variable is set. The motivation for this change is to speed up running sdist which gets executed at the begining of a tox run. Some projects (like Nova) can take between 10-20 seconds to generate a changelog in this fashion. Change-Id: I2e75060d303bc8fae784129e8e42f09922a8b09e
* | Fix missing gettextutils in several modules.Eric Windisch2012-07-1210-0/+11
| | | | | | | | | | | | Fixes bug 1021453. Change-Id: I05771a588746a0e43fec0078c5c7152dd9d33b9f
* | Merge "Fix line length for pep8 compliance after cloning into other projects"Jenkins2012-07-113-5/+11
|\ \
| * | Fix line length for pep8 compliance after cloning into other projectsDoug Hellmann2012-07-113-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a few lines that are close to the length limit so they pass the PEP8 check under the common repository but fail the check after the code is cloned into another project such as ceilometer. These changes adjust the lines to give more space to allow the merge into the other projects to go ahead without breaking the pep8 gating tests. Change-Id: I33a05f5b51120114cc8ceffd0bf1b1ef462ed636 Signed-off-by: Doug Hellmann <doug.hellmann@dreamhost.com>
* | | Merge "Add 'filedecoder' method to the jsonutils wrapper module."Jenkins2012-07-112-1/+10
|\ \ \
| * | | Add 'filedecoder' method to the jsonutils wrapper module.Tim Daly Jr2012-06-262-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug #1017765 After version 3.3.2, the anyjson library will throw a KeyError if filedecoder isn't present. The filedecoder is just like the decoder except it takes a file instead of a string, like json.load() instead of json.loads(). Change-Id: I7bd012a7b4afa9b1ec987c3e6393cc922b5dadff
* | | | Merge "cfg: Fix typo in documentation"Jenkins2012-07-111-2/+2
|\ \ \ \
| * | | | cfg: Fix typo in documentationVincent Untz2012-07-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with with -> with Change-Id: I7a524c024b05639ec7ab4d57b6a52f70a95d2235
generated by cgit (git 2.34.1) at 2025-09-29 00:40:15 +0000