| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
flake8 is pluggable and handles pep8 and pyflakes, as well as configuration
through tox.ini. It also removes the need for flakes.py.
Change-Id: If5f7d8ad348b4fb8119fa4ec7b5e9d17bdc72a39
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
looks like we were setting the wrong param
Fixes LP# 1158807
Change-Id: Id138926f737ce87618d625aa8b289c508a66aaf4
|
|\ \ \
| |/ /
|/| | |
|
| | |
| | |
| | |
| | | |
Change-Id: Idf2235300fa2c1c73563ddcff6ce9e84bd11ea0e
|
|\ \ \
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Co-authored-by lines are the way we've decided to indicated shared
authorship of a patch, so content from them should be included in
the generated AUTHORS file.
Fixes bug 1158319.
Change-Id: I9dacf78c01f3ad74e696f16a7aa39edb98e8d185
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes bug 1158179
In the case that the lock_path does not exist and there is a contested
resource then the process that was waiting on the lock will not
be locking due to the fact that the directory was deleted.
Change-Id: I75d720d4df499e85386d3e2cc86b927b017e12ac
|
|\| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add a unit test which fails because of #1107950 - in this case,
lockutils is deleting the lock directory every time the lock is dropped
even though another process might have acquired a lock using that
directory.
Change-Id: Ic82409f9462e570bc102ab469334c53aafc6d7ac
|
|\ \ \ \ |
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Because we need compatibility with Grizzly (N-1 support), this should be
reduced to two copies for Havana, before stripping down to a singular
copy for I.
The '-reply' request has its context key removed, with the
msg option maintaining one extra copy of context until I.
A TODO has been entered to clean this up following the Havana release.
This fix eliminates an extra JSON double-deserialization routine.
The double-serialization of context is still performed for Grizzly
compatibility.
fixes bug 1156956
Change-Id: I071e382ec9c7e0df3794fe9ca574a5722f8910a6
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This patch moves the traceback for an rpc timeout from inside an
iterator, which gave a useless traceback, into the main flow of the
program.
It also adds the rpc method being called and the topic used to the
exception's message.
When the caller logs the message higher up the stack, the log
information and traceback will be more useful.
Finally it removes the timeout logging in the amqp.py module, in the
spirit of bug #1137994 and https://review.openstack.org/#/c/23295/
Works towards: bug #1148516
Change-Id: I29a3b1b97c6114c4479e2b71c1257c4d72131535
|
|\ \ \ \ \ |
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Grizzly had the ability to receive messages with an envelope, but did
not send them. Now update the code to send them.
Change-Id: I73aad7697cf83ad4aabb3c2058b7cc4f53f783c2
|
|\ \ \ \ \
| | |_|_|/
| |/| | | |
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Use a separate directory for the lockutils external locks and for the
test's flocks which are used to check that serialization is actually
occurring. By using the same directory, we can't test the code in
lockutils which auto-creates this directory because the dir gets
deleted by a process by lockutils cleanup while another directory
is using it for flocks.
Also, assume the the handles directory has been created in the parent
rather than having each child attempt to create it.
Related, add a try/finally block so that when a child process throws an
exception it immediately exits rather than deleting the temporary
directories created by the parent.
Change-Id: I32d7e8e05fb3f22cf38fa586f8bc97646c83f182
|
|\ \ \ \
| |_|/ /
|/| | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes bug #1154245
If the parameter to the --log-config option cannot be loaded by the
logging.config.fileConfig() function, you get an exception like this
raised:
NoSectionError: No section: 'formatters'
which doesn't do much to help users understand the error.
Improve the situation by wrapping the error in a custom exception type
giving this:
LogConfigError: Error loading logging config /etc/logging.conf: No section: 'formatters'
Also add some tests to check we raise this error under the most common
failure conditions.
Change-Id: I6ad2eb4867213b6356ce43d75da50218d1b498f6
|
|\ \ \ |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fix allows someone using openstack.common.wsgi to pass
kwargs down to eventlet.wsgi.server when calling wsgi.run_server.
Fixes bug 1156930
Change-Id: Id35232f68ee40c5435e157a834fc94d4bbd04970
|
|\ \ \
| |_|/
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes bug #1157597
Change-Id: I77e0ddb1babf1eec0bb953b8bfa52cd1d415f709
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
detailed-errors does not provide us any value in our use of runs,
and it actually breaks now that we're using standard unittest
protocol and testtools.
Change-Id: Ie5a36eaf022e3f3d47904aad0ba2efdfc0d85b34
|
|\ \ |
|
| |/
| |
| |
| |
| |
| | |
Fixes bug #1157596
Change-Id: I36d5484eaa2f0e21188eed6e70cc1ad785233d6a
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clarify that --log-dir is only applicable for
relative --log-file paths.
Also change the description of --log-file, to be less specific.
By changing "If not set" to "If no default is set", it
allows for a better description given the cumulative nature of
these config settings. Distributors can use this for example
to set a default in a distribution wide config file that is
then indicated by a commented default in a user editable file.
I.E. the following config file is now more accurate:
# Name of log file to output to.
# If no default is set, logging will go to stdout.
# log_file = /some/dist/default/set/elsewhere.conf
Change-Id: I9a39511b6d6cfff907471ab7a6f31c34592a1015
|
|
|
|
|
|
|
|
|
|
| |
fixes bug 1154745
The previous update (https://review.openstack.org/#/c/24103/) missed
header files that contained "OpenStack, LLC". This change corrects the
missed files to reflect the OpenStack Foundation.
Change-Id: I9c6de265267485ef2c82ea7e6d8643e82134d102
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Sockets are created by the zeromq driver
for the topic specified by each incoming message.
Because the topic is arbitrarily supplied by the sender,
path separators in the topic must be illegal.
Fixes bug 1122763
Change-Id: Iccdb9b69e646bfe7665ee34c367fd4019db25f17
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes bug #1122701
Allow:
module=foo
module=bar
rather than
modules=foo,bar
to make reviewing changes easier.
Change-Id: Ic0a7fb28fd34f530c93806a5fb79ed3dc3bc494e
|
|\ \ \ |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
log.setup() doesn't really initialize root logger, therefore logging
in 3rd party library such as stevedore doesn't work properly. This
patch enable root logger initialization.
Fix bug: # 1073241
Change-Id: I6fa41b2ba41ff97ad0280f8774a26887d294423e
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| | |
Fixes bug #1128256
oslo.config has now been released to PyPI in time for Grizzly RC1 so
we can switch to using it directly.
Change-Id: I655f831718ae5f4e25e941ee206fe195214a9a91
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
One code change, rest are in headers
Change-Id: I73f59681358629e1ad74e49d3d3ca13fcb5c2eb1
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Allow log_format option to be settable by the operator,
as per configure-logging documentation. Thanks to Marcus Furlong.
Fixes LP: #1124716
Change-Id: I15d39b3162643c22ff6c905ecbb2efa06e2d882f
|
|\ \ \ \
| |_|_|/
|/| | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes bug 1135539
When SysLogHandler is configured in UDP socket mode, the user
who doesn't have the admin privilege got the unexpecting internal
server error(HTTP 500) in "nova dns-create-private-domain" command.
This bug occurs as the call graph drew below:
|--ProxyCallback._process_data():amqp.py
|--LOG.exception()
| :
| |--BaseHub.switch():hub.py
| |-- clear_sys_exc_info()
|
|--ctxt.reply(None, sys.exc_info(),..)
|
:
|
|--serialize_remote_exception():common.py
|--failure_info#(None,None,None)
The sys.exc_info() is cleared by the clear_sys_exc_info(), but it is
called again by the ctxt.reply().
This patch prevents the internal error and returns the details of
the forbidden error(HTTP 403) which is expected.
Change-Id: I549b4b2365c53c401edc80bbe30bcde249d27b85
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| | |
The Windows Storage Cinder plugin through
the Windows Locks implementation
of the InterProcessLock fails in
attaching/detaching operations.
Change-Id: I682205592e152b3222e04ca3221d25594d134dd9
Fixes: bug #1153966
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Switch to using auth_token instead of auth_ok
Fixes LP# 1152826
Change-Id: I56569c1fa8f29b0474440c40644729d436d41c7b
|
|/
|
|
|
|
|
|
| |
It takes 15 seconds to generate the ChangeLog for nova. Without --stat,
it takes 0.5 seconds. Removing this makes using tox in nova about the
same speed as using install_venv/with_venv.
Change-Id: I626d5e788bfaf1a80b91d845f21af54680f81c35
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Boolean values for capabilities don't work because extra_specs are
all converted to unicode. The scheduler will then check, for example,
if the boolean 'True' is equal to the unicode string 'True', and will
always return False. This patch allows admins to specify '<is> True'
in extra_specs, which will compare successfully to boolean True.
Fixes bug: 1146306
Change-Id: Id0e6dcfb71eb0943a16bba551ec23c4d57206550
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Similar to what we did in 427769c we need to ignore checking
exit codes for patch -N command so that they can be run multiple
times.
The motivation here is that I would like to use this to patch
virtual env's created by tox. Tox doesn't provide a good hook
to call post_process (which patches files) only once so the
idea here is we'll just let it call post_process all the time...
Change-Id: I866e7a3e1fd492d7d4c08eb55cde02f2dfa16c9a
|