summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge changes I71d99f00,Ib91b5af0Jenkins2012-02-203-11/+77
|\ | | | | | | | | | | * changes: Add git changelog method. Add git vcsversion method.
| * Add git changelog method.Monty Taylor2012-02-093-11/+50
| | | | | | | | Change-Id: I71d99f00b2154bf151a1521016118ba6bd088f79
| * Add git vcsversion method.Monty Taylor2012-02-091-0/+27
| | | | | | | | | | | | | | | | Leaving in the branch_nick for now - I think we need to go through the projects using this code and ensure that they aren't going to get screwed before we remove it. Change-Id: Ib91b5af050244f44cd811ca47cb6e2c53ef74ddb
* | Merge "Use default values for requirements parsing."Jenkins2012-02-201-5/+2
|\ \
| * | Use default values for requirements parsing.Monty Taylor2012-02-091-5/+2
| |/ | | | | | | Change-Id: I88a38441d8f3e6e2ef02269c41d4590cbd4acbcf
* | cfg: unneeded multiple inheritanceZhongyue Luo2012-02-121-2/+2
| | | | | | | | | | | | | | | | | | | | Fixed bug #927650 In python=<2.6, collections.Mapping inherits from collections.Sized, collections.Iterable, and collections.Container which are also subclasses of object. Change-Id: I6238c683324127abd9fb637748a10b6bdb2961e0
* | PEP8 cleanup (openstack-common)Zhongyue Luo2012-02-117-33/+32
| | | | | | | | | | | | | | | | | | Fixes bug #930625 Remove backslash continuations in openstack-common. Fix type checking taboos. Change-Id: I49ddb9ff5fa5af760dcfccb52cb4793b71e02f19
* | Merge "Disable ConfigParser interpolation (lp#930270)"Jenkins2012-02-102-1/+13
|\ \
| * | Disable ConfigParser interpolation (lp#930270)Mark McLoughlin2012-02-102-1/+13
| |/ | | | | | | | | | | | | | | | | | | | | | | This breaks e.g. volume_name_template=volume-%08x instance_name_template=instance-%08x and is not part of the API contract anyway. We use $opt based value interpolation. Change-Id: I7ba566ae7c9a77322b52c67c5e1ffbffb760f0fc
* / Backslash continuations (misc.)Zhongyue Luo2012-02-101-25/+20
|/ | | | | | | | | | | Fixes bug #925166 This patch for packages which have few backslash continuations. Follow up patches will be for packages network, scheduler, virt, db/sqlalchemy, tests, and api/openstack. Change-Id: I4200010b47b33fa8b9115b5d379b543200f6668d
* Merge "Updated tox config for multi-python testing."Jenkins2012-02-098-34/+111
|\
| * Updated tox config for multi-python testing.Monty Taylor2012-02-068-34/+111
| | | | | | | | Change-Id: Ib1f768c6783db0e63cb51dfc767ae5a31a295c76
* | Merge "Split functions to avoid eventlet import."Jenkins2012-02-093-19/+44
|\|
| * Split functions to avoid eventlet import.Monty Taylor2012-02-063-19/+44
| | | | | | | | | | | | | | | | | | | | Some of these functions are used in setup.py. In a virtualenv based workflow, python setup.py sdist is called to create a tarball which is then installed into the virtualenv. These functions need to be in a separate file so that they can be imported by setup.py without eventlet needing to be installed. Change-Id: I6f7dc9614895b8c91135c62373b98afe55e1fc7d
* | fix namespace declarationJason Kölker2012-02-081-0/+1
|/ | | | Change-Id: Ib23b9a264173f061afeb72809a9ac40f907d419a
* Implements blueprint separate-nova-volumeapiAnthony Young2012-02-021-4/+4
| | | | | | | | [...] ** Removes flag osapi_extension and replaces with osapi_compute_extension and osapi_volume_extension [...] Change-Id: I4c2e57c3cafd4e1a9e2ff3ce201c8cf28326afcd
* Makes common/cfg.py raise AttributeErrorVishvananda Ishaya2012-02-022-1/+6
| | | | | | | * fixes bug 915039 * includes test Change-Id: I67b886be3b5af3763f52fffe54085975d61d61eb
* PEP8 type comparison cleanuplzyeval2012-02-021-1/+1
| | | | | | | | | | | | | | | | Fixes bug #910295 The None, True, and False values are singletons. All variable *comparisons* to singletons should use 'is' or 'is not'. All variable *evaluations* to boolean should use 'if' or 'if not'. "== None", "== True", "== False", and "!= None" comparisons in sqlalchemy's where(), or_(), filter(), and_(), and select() functions should not be changed. Incorrect comparisons or evaluations in comments were not changed. Change-Id: I087f0883bf115b5fe714ccfda86a794b9b2a87f7
* Add the Mapping interface to cfg.ConfigOptsMark McLoughlin2012-01-272-11/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements blueprint cfg-mapping interface With cfg, option values are accessed via attributes on ConfigOpts objects e.g. conf = ConfigOpts() conf.register_opt(StrOpt('foo')) conf() print conf.foo One use case that isn't easily supported with option values represented this way is iterating over all the registered options. Standard interfaces for listing attributes on an object aren't suitable because they will list more than just the options. For this use case alone, it's worth having ConfigOpts implement the mapping interface. That way we can do e.g. for opt, value in conf.items(): print "Option %s = %s" % (opt, value) It's interesting to compare argparse's approach to this problem - option values are attributes on a Namespace object which has no attributes or methods to pollute the namespace of option names. This is a nice approach, but would mean that we would be passing around both a ConfigOpts object and a Namespace object. That's a bit too much overhead, and the mapping interface provides a usable workaround where there is a conflict. Change-Id: Ic113919a20291048f962999229c76884ebdd5ad8
* Re-factor update.py to avoid breaking testsMark McLoughlin2012-01-271-56/+74
| | | | | | | | | | | | nosetests tries to import update.py and fails. Re-factor the code so that we have a main function that doesn't get executed on import. Note: setup.py would break nose similarly, except nose ignores setup.py by default. Change-Id: I609019d492f6fc2d7f2e8b6165228f879cf1ddb7
* Add a script to copy code into other projectsMark McLoughlin2012-01-261-0/+157
| | | | | | See: http://wiki.openstack.org/CommonLibrary#Incubation Change-Id: Ie90d40952909f766fdcac38379bf6b1ac1a0e5c7
* Pull openstack.nose_plugin from pypiJason Kölker2012-01-231-2/+1
| | | | Change-Id: I54372df3f42b806e37a71338d2779887d1c591ce
* Merge "Add support to cfg for disabling interspersed args"Jenkins2012-01-232-0/+53
|\
| * Add support to cfg for disabling interspersed argsMark McLoughlin2012-01-232-0/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements blueprint cfg-disable-interspersed-args Nova currently relies on cfg being implemented with optparse because it uses optparse's disable_interspersed_args() The use case for this is if you do: $> nova-manage --verbose create --project foo --user bar you want invoking ConfigOpts() to return: ['create', '--project', 'foo', '--user', 'bar'] as the "extra" args rather than aborting when it doesn't recognize the --project arg. This is a reasonable use case for cfg to support and it should just have {disable,enable}_interspersed_args() methods. If we ever switch from optparse to argparse, we'll do something like this: parser.add_argument('--verbose') ... parser.add_argument( 'extra_args', nargs=argparse.REMAINDER if disable_interspersed_args else '*') ... ns = parser.parse_args(...) extra_args = ns.extra_args i.e. we will need an 'extra_args' multi-value positional argument in any case and we'll just pass nargs=REMAINDER if we want trailing options to be included in the extra args. Change-Id: I3ecb7dc18230327cf5aaaa7d832224e64aafa40c
* | Add cfg test case for recursive substitutionMark McLoughlin2012-01-231-0/+8
|/ | | | | | | i.e. test that if blaa='blaa', foo='$blaa' and bar='$foo' that the value of bar after substitutions is 'blaa' Change-Id: I01d370832a871603b7cb47bfb3546f6aaad8c34d
* Get cfg test cases to 100%Mark McLoughlin2012-01-121-5/+91
| | | | | | | | | | | | * Test cfg.find_config_files() sys.argv usage * Test boolean values in cfg config files * Finish off incomplete cfg bad value test case * Test register_opts() and register_cli_opts() * Test the quiet ignoring of option/group re-registration * Test cfg print_usage() * Test explicit option group titles Change-Id: Icbe4b7c48d4785551f06873821d1be758adf942c
* Add cfg test case for exceptions' __str__ methodsMark McLoughlin2012-01-121-0/+39
| | | | | | Increases coverage from 93% to 97% Change-Id: I6a41b31e29238831fe2a888d5d64dc0bffd770c0
* Fix some cfg test case naming conflictsMark McLoughlin2012-01-121-18/+18
| | | | | | | | | | | | | As pointed out by Vish, there are duplicates of: OverridesTestCase::test_default_override OverridesTestCase::test_override SadPathTestCase::test_conf_file_not_found Also, rename the ConfigFileOptsTestCase so it is obvious they don't clash with the tests by the same name in CliOptsTestCase. Change-Id: I1d650d05d32501623cfed8f0b6399858d101ae02
* Add new cfg moduleMark McLoughlin2012-01-102-0/+1908
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As described here: http://wiki.openstack.org/CommonConfigModule The module implements an API for defining configuration options and reading values for those options that a user may have set in a config file or on the command line. The module is successfully in use in both Nova and Glance. Some work remains in Nova to switch from using it under a gflags compatible shim layer, but Glance is using it fully. There doesn't appear to be any blockers to other projects moving over to it fairly easily. Swift would perhaps be the next project to tackle. Just to go through potential future compatibility concerns: - Nova (the scroundrel) hackily uses the private ConfigOpts::_oparser in order to disable interspersed args. This was just for nova-manage and can probably be resolved some other way. In any case, Nova shouldn't switch to openstack-common's cfg API until it removes this hack. - the CommonConfigOpts subclass set of logging related options is perhaps assuming too much about what configuration options should be common across all the projects. However, it seems a fairly sane set and the worst that can happen is that projects avoid using it. - the parameters to the Opt constructor fairly closely mirror optparse, but they're fairly generic and shouldn't prevent us from switching to e.g. argparse - stuff like %prog expansion in the ConfigOpt's usage ctor param is a similar concern, but it's a very minor concern. - find_config_files() search path is perhaps too much policy for openstack-common; however, it is probably as generic as it could be and projects which need a different policy can just not use the function On the whole, I think we're in good shape wrt future compatibility. Change-Id: I279a9db7806d80aff3b9b085b4a9e4fb193662f9
* Merge pull request #3 from emonty/masterJason Kölker2012-01-065-104/+23
|\ | | | | Use latest tissue update - ready for gerrit
| * Updated README with instructions.Monty Taylor2012-01-061-1/+11
| |
| * Removed run_tests.sh in favor of tox.Monty Taylor2012-01-061-103/+0
| |
| * Added .gitreview file.Monty Taylor2012-01-061-0/+4
| |
| * Added tissue support back in.Monty Taylor2012-01-062-0/+8
|/
* make sure a '_' function is availible for noseJason Kölker2012-01-041-0/+2
|
* Merge pull request #1 from emonty/masterJason Kölker2012-01-046-447/+20
|\ | | | | Changes to make things use tox
| * Use nose and tox.Monty Taylor2012-01-044-447/+0
| |
| * Added pip-requires and tox.ini to run tests.Monty Taylor2012-01-042-0/+20
|/
* add some server testsJason Kölker2011-12-021-0/+20
|
* moar utils testsJason Kölker2011-12-021-0/+53
|
* import should not return an instance of the classJason Kölker2011-12-021-2/+1
|
* add utils testJason Kölker2011-12-011-0/+70
|
* use isinstance and types.*Jason Kölker2011-12-011-2/+2
|
* add context middleware testsJason Kölker2011-12-012-0/+79
|
* add more coverage to test_extensionsJason Kölker2011-12-011-1/+66
|
* add exceptions test coverageJason Kölker2011-12-011-0/+151
|
* add context 'tests'Jason Kölker2011-12-011-0/+27
|
* add more config testsJason Kölker2011-12-011-3/+61
|
* make fix_path a real function so it can be mock'dJason Kölker2011-12-011-1/+7
|
* remove unused importsJason Kölker2011-12-011-2/+0
|
generated by cgit (git 2.34.1) at 2025-09-29 15:45:50 +0000