summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Remove the notifier and its dependencies from log.pyDavanum Srinivas2013-05-143-14/+38
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Move the code related to the publish error handler out of the log module so its easier for other projects to consume it Fixes LP #1179528 Change-Id: Ibf28ba17f81b5ddeda653f6a3501ecac18ffcd42
* | | Merge "Fixes import order nits"Jenkins2013-05-169-8/+9
|\ \ \
| * | | Fixes import order nitsZhongyue Luo2013-05-159-8/+9
| | | | | | | | | | | | | | | | Change-Id: I4fdc8eed74dd90d6450864daba7492d5e7266448
* | | | Merge "Update KillFilter to stop at '\0' for readlink() function."Jenkins2013-05-162-0/+16
|\ \ \ \
| * | | | Update KillFilter to stop at '\0' for readlink() function.Yufang Zhang2013-05-152-0/+16
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Python's readlink() implementation doesn't stop at '\0' when reading file path. Thus after dnsmasq upgrade, it may return something like '/usr/sbin/dnsmasq\03453 (deleted)', while C's or Shell's readlink() return '/usr/sbin/dnsmasq'. This patch fixes this problem by cutting the readlink() results with '\0', so that KillFilter could get correct path. Bug 1179793 Change-Id: I7354941e0508e019c8c9b63b87ad39f52ccb51ca
* | | | Support capping message versions in the client.Russell Bryant2013-05-153-3/+21
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When doing a rolling upgrade, we need to be able to tell all rpc clients to hold off on sending newer versions of messages until all nodes understand the new message version. This patch adds the oslo component of this. It's quite simple. The rpc proxy just stores the version cap and will raise an exception if code ever tries to send a message that exceeds this cap. Allowing the cap to be configured and generating different types of messages based on the configured value is the hard part here, but that is left up to the project using the rpc library. Implements blueprint rpc-version-control. Change-Id: Ia69db03a80dc3b1c63d52c7e163ea3cfec80c882
* | | Merge "Adds --nodeps option to update.py"Jenkins2013-05-151-2/+7
|\ \ \ | |_|/ |/| |
| * | Adds --nodeps option to update.pyZhongyue Luo2013-05-141-2/+7
| |/ | | | | | | | | | | Discards dependencies of configured modules when set. Change-Id: I4210c9b2d96d4c0750175823b47e39b4097be6ac
* | Merge "Add 't', 'y', and `strict` to `bool_from_string`"Jenkins2013-05-152-14/+92
|\ \ | |/ |/|
| * Add 't', 'y', and `strict` to `bool_from_string`Rick Harris2013-05-142-14/+92
| | | | | | | | | | | | | | | | | | | | | | 't' and 'y' are commonly used for booleans as well, and since it's used in Nova already, probably makes sense to add common support for it. `strict` allows callers to detect anonmolous values so they can be handled separately. This is particularly useful when parsing input from API calls where bad values might result in 4XX errors instead of being treated as False. Change-Id: I6218a1895f72cfbfd81776602e63ca3d093475e0
* | Merge "Update eventlet bug URL."Jenkins2013-05-131-1/+2
|\ \
| * | Update eventlet bug URL.James E. Blair2013-05-131-1/+2
| | | | | | | | | | | | | | | | | | | | | The eventlet repository has moved, so the bug url referenced in the comment about why we patch eventlet needs to be updated. Change-Id: I55abe0b6eb4c8e21fad15a10d6ec71d3b5a59e54
* | | Merge "Removes len() on empty sequence evaluation"Jenkins2013-05-136-10/+8
|\ \ \
| * | | Removes len() on empty sequence evaluationZhongyue Luo2013-05-136-10/+8
| | |/ | |/| | | | | | | | | | | | | PEP8 suggestes, "For sequences, use the fact that empty sequences are false." Change-Id: I4c600a7a6230a55328ee46f7c59f340f37abc18f
* | | Merge "Line wrapper becomes to long when expanded."Jenkins2013-05-131-2/+3
|\ \ \
| * | | Line wrapper becomes to long when expanded.Monty Taylor2013-05-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | Projects with long names, such as ceilometer, trip up on this line. Change-Id: I51ff3f0250018215ae240f90cec6051b56aab434
* | | | Merge "Renames filter to base_filter and weight to base_weight"Jenkins2013-05-136-9/+139
|\ \ \ \
| * | | | Renames filter to base_filter and weight to base_weightMatthew Sherborne2013-05-106-9/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | filter is a python builtin function so importing it pollutes ones name space. It is now renamed to base_filter. We also rename weight to base_weight, just to be consistent in the naming conventions. We add a test for base_filter. Fixes bug 1175829 Change-Id: I46e0fa696d2f39081b5568c701b0a70c54f271ab
* | | | | Merge "python3: use 'as' syntax for exception assignment"Jenkins2013-05-131-1/+1
|\ \ \ \ \ | |_|_|/ / |/| | | |
| * | | | python3: use 'as' syntax for exception assignmentChuck Short2013-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From http://docs.python.org/3.1/whatsnew/3.0.html The except exc as var syntax is now standard and except exc, var is no longer supported. Change-Id: Ia3a11d72c474806cc2303a7fc9cb1a390266c0fb Signed-off-by: Chuck Short <chuck.short@canonical.com>
* | | | | Merge "Minor README improvement"Jenkins2013-05-112-11/+31
|\ \ \ \ \
| * | | | | Minor README improvementMark McLoughlin2013-05-092-11/+31
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Make it a .rst, add a link to the wiki page, mention that this repo is an incubator. Change-Id: I47a1b6f5811ce476393ac94c3b11eec61b3984e3
* | | | | Merge "Handle ints passed to `boolean_from_string`"Jenkins2013-05-112-6/+21
|\ \ \ \ \ | |_|_|_|/ |/| | | |
| * | | | Handle ints passed to `boolean_from_string`Rick Harris2013-05-102-6/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The existing code would return True for '1' but False for int(1), unlike Nova's version which would return True for both inputs. Nova's version feels safer (i.e. it will do the most-likely-correct thing if an int is passed in), so this patch changes Openstack-Common's version to match. Note that this patch does not make Openstack-Common's `boolean_from_string` match Nova's `bool_from_string` exactly though. Nova's version would return True for both '42' and 42, while Openstack-Common's returns False. Though Nova's version, again, seems safer, the presence of unit-tests in Openstack-Common asserting the defined-correctness of this behavior makes me reluctant to change it. Fixes bug 1178760 Change-Id: I8b2a31c4852884187bcbda3a4e78c8513b1bb8c8
* | | | | Merge "Removes leading zeros on integers in test_timeutils"Jenkins2013-05-101-13/+13
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Removes leading zeros on integers in test_timeutilsZhongyue Luo2013-05-101-13/+13
| |/ / / | | | | | | | | | | | | Change-Id: If1cb92ba0ff1a57ab8940d9f9e1fe66ffd34441a
* | | | Merge "Added convenience APIs for lockutils"Jenkins2013-05-102-0/+45
|\ \ \ \
| * | | | Added convenience APIs for lockutilsZhongyue Luo2013-05-092-0/+45
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The lock_file_prefix for each project doesn't need to be configurable or frequently changed. This patch provides a convenience API which returns a partial object of the synchronized decorator to avoid passing the prefix each time locks are used. The set_defaults method is also provided to change the default value of lock_path when needed. Fixes bug #1065524 Change-Id: I7b67f0a482da4be6d53a70db5bbd22dc91bdc10c
* | | | Merge "Convert unicode strings for python3 portability"Jenkins2013-05-104-56/+45
|\ \ \ \
| * | | | Convert unicode strings for python3 portabilityChuck Short2013-05-075-56/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From http://docs.python.org/3.1/whatsnew/3.0.html You can no longer use u"..." literals for Unicode text. However, you must use b"..." literals for binary data. Use python-six to make this migration easier. Change-Id: I95166a07f4edf33be55a4bdf2674c2f238a06f19 Signed-off-by: Chuck Short <chuck.short@canonical.com>
* | | | | Merge "Stylistic improvements from quantum-rootwrap"Jenkins2013-05-102-15/+13
|\ \ \ \ \
| * | | | | Stylistic improvements from quantum-rootwrapThierry Carrez2013-05-092-15/+13
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of the convergence effort between oslo-rootwrap and quantum-rootwrap, import stylistic improvements introduced in quantum-rootwrap, like: - HACKING-compliant docstrings - More elegant return construct from match_filter in filters.py - Remove overridden use of filters in wrapper.py Change-Id: I49a97271b1c385feb25adf4f62add5c71962b5dd
* | | | | Merge "Adds timeutils and uuidutils maintainer"Jenkins2013-05-101-4/+4
|\ \ \ \ \
| * | | | | Adds timeutils and uuidutils maintainerZhongyue Luo2013-05-071-4/+4
| | |_|/ / | |/| | | | | | | | | | | | | Change-Id: I233de16bed565bbe37950503e8b62890f9b4c1d1
* | | | | Merge "Import trycmd and ssh_execute from nova."Jenkins2013-05-102-0/+151
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Import trycmd and ssh_execute from nova.Michael Still2013-05-072-0/+151
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | This change required adding basic unit tests as well as these were both untested in nova. Change-Id: If6843e57810198aab3c61f9eb3c3a6f42f710f7c
* | | | Merge "Copy Nova's workaround for RHEL6 eventlet issue"Jenkins2013-05-085-4/+68
|\ \ \ \ | |_|_|/ |/| | |
| * | | Copy Nova's workaround for RHEL6 eventlet issueMark McLoughlin2013-05-085-4/+68
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The eventlet on PyPI basically doesn't work on RHEL because we (Red Hat) screwed up by not taking monkey patching into account when backporting an API from python 3. This is the series of events: 1) We backported a patch to RHEL6 from Python 3 which added an optional 'timeout' argument to subprocess.Popen: http://pkgs.devel.redhat.com/cgit/rpms/python/commit/?h=rhel-6.3&id=fc9a3f0e07 This might sound innocuous but it means the wait() function get called with a timeout argument 2) eventlet overrides this function, but doesn't know about the timeout argument, so it fails. To reproduce, try applying this to your python 2.7: https://gist.github.com/markmc/5500967 3) eventlet doesn't yet support Python 3, so the only time this issue crops up is if you use eventlet on RHEL6 4) We've fixed eventlet in EPEL6, but the issue still remains if you install eventlet from upstream 5) Dave Malcolm sent a pull request to eventlet, but it has stalled: https://bitbucket.org/eventlet/eventlet/pull-request/30/add-dummy-timeout-parameter-to Nova has long had a nasty workaround to patch eventlet in our virtualenv and we now need this workaround in oslo-incubator to test processutils. Let's add it here and make nova sync it from oslo-incubator. I really hope we can get eventlet upstream "fixed" and the fix released soon. When that happens, we can kill all this nastiness. Change-Id: I62ce43a330d7ae94eda4c7498782a655e63747fa
* | | Merge "Convert unicode for python3 portability"Jenkins2013-05-079-18/+34
|\ \ \ | |/ / |/| |
| * | Convert unicode for python3 portabilityChuck Short2013-05-069-18/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From http://docs.python.org/3.1/whatsnew/3.0.html: "Python 3.0 uses the concepts of text and (binary) data instead of Unicode strings and 8-bit strings." Use six.text_type to Type for representing (Unicode) textual data. This is unicode() in Python 2 and str in Python 3. Change-Id: I3da268a714a34a8e626a2590f01b86e414dc3411 Signed-off-by: Chuck Short <chuck.short@canonical.com>
* | | Merge "Add test coverage for sqlite regexp function"Jenkins2013-05-031-1/+58
|\ \ \
| * | | Add test coverage for sqlite regexp functionMark McLoughlin2013-05-021-1/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add some tests which for the regexp function which we install for sqlite. Need test coverage to catch e.g. a regression of the fix for bug #1031846. Change-Id: I4bd77d0d93c4fc85588e6e6d5a559e68133dbf73
* | | | Merge "Deprecate log_format and change default to None"Jenkins2013-05-032-14/+34
|\ \ \ \
| * | | | Deprecate log_format and change default to NoneAndrew Laski2013-05-012-14/+34
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 3e71cc4c8c7e08784f44c2e337a585e562b93ec5 fixed an issue with ignoring log_format, but changed the default logging formatter. This led to being unable to use the former context aware formatter without configuring log_format='' explicitly. This change sets log_format to None so that the default is a context aware formatter, but setting log_format works as intended. Additionally, since log_format is mutually exclusive with some of the other config formatting options, such as logging_default_format_string, it should be deprecated. Bug 1167388 Change-Id: I281ed7fe3448403f27a4cd318fc21915027906cc
* | | | Merge "Update processutils."Jenkins2013-05-032-12/+141
|\ \ \ \
| * | | | Update processutils.Michael Still2013-05-032-12/+141
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is another example of something which was imported from nova but where nova was never moved across to use the oslo version. The code has since diverged. This review syncs up the two versions, and will be followed by a nova review to move nova across to the oslo implementation. Unit test coverage for this new version is 83%. I want to improve that, but I'll do it in a later review. I will also need to update cinder, quantum and nova to this new version of the code once this merges. I will do moniker as well because I am a nice guy. Change-Id: Ie0731c56c9aab547b5d5b905bf4ed8eff3eae3bd
* / | | Improve python3 compatibilityChuck Short2013-05-025-31/+41
|/ / / | | | | | | | | | | | | | | | | | | | | | Change print statements so that it works with python3 as well. Change-Id: Iff16b62e4b875c79862c9af7726ea77627aa7b4f Signed-off-by: Chuck Short <chuck.short@canonical.com>
* | | I'll maintain periodic_task as well.Michael Still2013-05-021-2/+2
| | | | | | | | | | | | | | | | | | I missed this one in the previous pass. Change-Id: I6be4610859f1e716e7b77a850c4b3080d7a154ce
* | | Mark myself as a maintainer.Michael Still2013-05-021-6/+6
|/ / | | | | | | | | | | | | I've been cleaning up these three modules, so I may as well be their maintainer as well. This was briefly discussed at the summit. Change-Id: I3282eee857c89d3b91e5d3bdb42694c1497219a9
* | Merge "Use optparse for install_venv_common"Jenkins2013-05-011-7/+10
|\ \