diff options
| author | Mark McLoughlin <markmc@redhat.com> | 2013-05-02 09:44:30 +0100 |
|---|---|---|
| committer | Mark McLoughlin <markmc@redhat.com> | 2013-05-08 06:48:20 +0100 |
| commit | 3c132c028a089936eb205079ad239347bc1a0dd9 (patch) | |
| tree | 4e499d3eeef0c581c37f9f214c77a8cf0ce9afdb /MAINTAINERS | |
| parent | f9d502228752bcb909e58cafacd1cd948d9a8206 (diff) | |
| download | oslo-3c132c028a089936eb205079ad239347bc1a0dd9.tar.gz oslo-3c132c028a089936eb205079ad239347bc1a0dd9.tar.xz oslo-3c132c028a089936eb205079ad239347bc1a0dd9.zip | |
Copy Nova's workaround for RHEL6 eventlet issue
The eventlet on PyPI basically doesn't work on RHEL because we (Red Hat)
screwed up by not taking monkey patching into account when backporting
an API from python 3. This is the series of events:
1) We backported a patch to RHEL6 from Python 3 which added an
optional 'timeout' argument to subprocess.Popen:
http://pkgs.devel.redhat.com/cgit/rpms/python/commit/?h=rhel-6.3&id=fc9a3f0e07
This might sound innocuous but it means the wait() function get
called with a timeout argument
2) eventlet overrides this function, but doesn't know about the
timeout argument, so it fails. To reproduce, try applying this to
your python 2.7:
https://gist.github.com/markmc/5500967
3) eventlet doesn't yet support Python 3, so the only time this issue
crops up is if you use eventlet on RHEL6
4) We've fixed eventlet in EPEL6, but the issue still remains if you
install eventlet from upstream
5) Dave Malcolm sent a pull request to eventlet, but it has stalled:
https://bitbucket.org/eventlet/eventlet/pull-request/30/add-dummy-timeout-parameter-to
Nova has long had a nasty workaround to patch eventlet in our virtualenv
and we now need this workaround in oslo-incubator to test processutils.
Let's add it here and make nova sync it from oslo-incubator.
I really hope we can get eventlet upstream "fixed" and the fix released
soon. When that happens, we can kill all this nastiness.
Change-Id: I62ce43a330d7ae94eda4c7498782a655e63747fa
Diffstat (limited to 'MAINTAINERS')
| -rw-r--r-- | MAINTAINERS | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/MAINTAINERS b/MAINTAINERS index 83822b1..aaeaa07 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -205,6 +205,13 @@ M: Michael Still <mikal@stillhq.com> S: Maintained F: processutils.py +== redhat-eventlet.patch == + +M: Mark McLoughlin <markmc@redhat.com> +S: Maintained +F: contrib/redhat-eventlet.patch +F: tools/patch_tox_venv.py + == rootwrap == M: Thierry Carrez <thierry@openstack.org> |