summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhongyue Luo <zhongyue.nah@intel.com>2013-03-20 15:48:26 +0800
committerZhongyue Luo <zhongyue.nah@intel.com>2013-03-21 09:13:35 +0800
commit4bb00aa8f0e7fb7181ffe6299dfd2a31b860e5c1 (patch)
treea771ff3357d1ec85c0aa08ccfa00d0eda5846870
parent341ce35316808acab1fc94462fdaa97c51b28bd4 (diff)
downloadoslo-4bb00aa8f0e7fb7181ffe6299dfd2a31b860e5c1.tar.gz
oslo-4bb00aa8f0e7fb7181ffe6299dfd2a31b860e5c1.tar.xz
oslo-4bb00aa8f0e7fb7181ffe6299dfd2a31b860e5c1.zip
Adds pylint section in tox.ini to check for unused imports
Fixes bug #1157597 Change-Id: I77e0ddb1babf1eec0bb953b8bfa52cd1d415f709
-rw-r--r--tools/lint.py34
-rw-r--r--tox.ini7
2 files changed, 40 insertions, 1 deletions
diff --git a/tools/lint.py b/tools/lint.py
new file mode 100644
index 0000000..69b88ca
--- /dev/null
+++ b/tools/lint.py
@@ -0,0 +1,34 @@
+# vim: tabstop=4 shiftwidth=4 softtabstop=4
+
+# Copyright (c) 2013 Intel Corporation.
+# All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+# @author: Zhongyue Luo, Intel Corporation.
+#
+
+import sys
+
+from pylint import lint
+
+
+ENABLED_PYLINT_MSGS = ['W0611']
+
+
+def main(dirpath):
+ enable_opt = '--enable=%s' % ','.join(ENABLED_PYLINT_MSGS)
+ lint.Run(['--reports=n', '--disable=all', enable_opt, dirpath])
+
+if __name__ == '__main__':
+ main(sys.argv[1])
diff --git a/tox.ini b/tox.ini
index f737a39..b0ca53e 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,5 +1,5 @@
[tox]
-envlist = py26,py27,pep8
+envlist = py26,py27,pep8,pylint
[testenv]
setenv = VIRTUAL_ENV={envdir}
@@ -16,6 +16,11 @@ commands = nosetests --with-doctest --exclude-dir=tests/testmods {posargs}
[testenv:pep8]
commands = pep8 --repeat --show-source --exclude=.venv,.tox,dist,doc,*.egg,.update-venv .
+[testenv:pylint]
+deps = pylint>=0.26.0
+commands = python ./tools/lint.py ./openstack
+ python ./tools/lint.py ./tests
+
[testenv:cover]
setenv = NOSE_WITH_COVERAGE=1