From c1c068bb6bad003df451f0fa5ceb2b85bdf799a2 Mon Sep 17 00:00:00 2001 From: Monty Taylor Date: Wed, 15 Aug 2012 15:39:43 -0400 Subject: Make missing imports flag in hacking settable. Change-Id: Ib1ada320588eb42370c9fa2c0eff4eb888258ea5 --- tools/hacking.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'tools') diff --git a/tools/hacking.py b/tools/hacking.py index 4eb2141f7..88d074794 100755 --- a/tools/hacking.py +++ b/tools/hacking.py @@ -47,7 +47,7 @@ logging.disable('LOG') IMPORT_EXCEPTIONS = ['sqlalchemy', 'migrate', 'nova.db.sqlalchemy.session'] DOCSTRING_TRIPLE = ['"""', "'''"] -VERBOSE_MISSING_IMPORT = False +VERBOSE_MISSING_IMPORT = os.getenv('HACKING_VERBOSE_MISSING_IMPORT', 'False') # Monkey patch broken excluded filter in pep8 @@ -218,9 +218,10 @@ def nova_import_module_only(logical_line): else: name = logical_line.split()[1] if name not in _missingImport: - if VERBOSE_MISSING_IMPORT: - print >> sys.stderr, ("ERROR: import '%s' failed: %s" % - (name, exc)) + if VERBOSE_MISSING_IMPORT != 'False': + print >> sys.stderr, ("ERROR: import '%s' in %s " + "failed: %s" % + (name, pep8.current_file, exc)) _missingImport.add(name) added = False sys.path.pop() -- cgit