From 4ac268a4b620eecc4af1f4ffdc0a836d7260d126 Mon Sep 17 00:00:00 2001 From: Steven Dake Date: Mon, 4 Mar 2013 10:31:10 -0700 Subject: docs should indicate proper git commit limit The nova gate should recommend 50 characters or less for a git commit but actually enforce 72 characters. This patch changes the hacking.rst docs to indicate the actual limit is 72 characters rather then 50 characters. Change-Id: I47f1f1f1007f5744bf1fef419df7e033803b4a53 Fixes: Bug #1144840 --- tools/hacking.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'tools') diff --git a/tools/hacking.py b/tools/hacking.py index e339966ee..4e2331054 100755 --- a/tools/hacking.py +++ b/tools/hacking.py @@ -596,7 +596,7 @@ def once_git_check_commit_title(): nova HACKING recommends not referencing a bug or blueprint in first line, it should provide an accurate description of the change N801 - N802 Title limited to 50 chars + N802 Title limited to 72 chars """ #Get title of most recent commit @@ -621,6 +621,8 @@ def once_git_check_commit_title(): "description of the change, not just a reference to a bug " "or blueprint" % title.strip()) error = True + # HACKING.rst recommends commit titles 50 chars or less, but enforces + # a 72 character limit if len(title.decode('utf-8')) > 72: print ("N802: git commit title ('%s') should be under 50 chars" % title.strip()) -- cgit