From 738bcb7d381a67b0884d861c7ad48fa08e37106a Mon Sep 17 00:00:00 2001
From: Michael Gundlach <michael.gundlach@rackspace.com>
Date: Wed, 18 Aug 2010 10:39:59 -0400
Subject: Newest pylint supports 'disable=', not 'disable-msg='

---
 nova/test.py                       | 10 +++++-----
 nova/tests/objectstore_unittest.py | 16 ++++++++--------
 2 files changed, 13 insertions(+), 13 deletions(-)

(limited to 'nova')

diff --git a/nova/test.py b/nova/test.py
index c392c8a84..a75e0de1a 100644
--- a/nova/test.py
+++ b/nova/test.py
@@ -53,7 +53,7 @@ def skip_if_fake(func):
 
 class TrialTestCase(unittest.TestCase):
     """Test case base class for all unit tests"""
-    def setUp(self): # pylint: disable-msg=C0103
+    def setUp(self): # pylint: disable=C0103
         """Run before each test method to initialize test environment"""
         super(TrialTestCase, self).setUp()
 
@@ -63,7 +63,7 @@ class TrialTestCase(unittest.TestCase):
         self.stubs = stubout.StubOutForTesting()
         self.flag_overrides = {}
 
-    def tearDown(self): # pylint: disable-msg=C0103
+    def tearDown(self): # pylint: disable=C0103
         """Runs after each test method to finalize/tear down test environment"""
         super(TrialTestCase, self).tearDown()
         self.reset_flags()
@@ -94,7 +94,7 @@ class TrialTestCase(unittest.TestCase):
 class BaseTestCase(TrialTestCase):
     # TODO(jaypipes): Can this be moved into the TrialTestCase class?
     """Base test case class for all unit tests."""
-    def setUp(self): # pylint: disable-msg=C0103
+    def setUp(self): # pylint: disable=C0103
         """Run before each test method to initialize test environment"""
         super(BaseTestCase, self).setUp()
         # TODO(termie): we could possibly keep a more global registry of
@@ -106,7 +106,7 @@ class BaseTestCase(TrialTestCase):
         self._done_waiting = False
         self._timed_out = False
 
-    def tearDown(self):# pylint: disable-msg=C0103
+    def tearDown(self):# pylint: disable=C0103
         """Runs after each test method to finalize/tear down test environment"""
         super(BaseTestCase, self).tearDown()
         for x in self.injected:
@@ -137,7 +137,7 @@ class BaseTestCase(TrialTestCase):
         if self._waiting:
             try:
                 self.ioloop.remove_timeout(self._waiting)
-            except Exception: # pylint: disable-msg=W0703
+            except Exception: # pylint: disable=W0703
                 # TODO(jaypipes): This produces a pylint warning.  Should
                 # we really be catching Exception and then passing here?
                 pass
diff --git a/nova/tests/objectstore_unittest.py b/nova/tests/objectstore_unittest.py
index dece4b5d5..5b956fccf 100644
--- a/nova/tests/objectstore_unittest.py
+++ b/nova/tests/objectstore_unittest.py
@@ -56,7 +56,7 @@ os.makedirs(os.path.join(OSS_TEMPDIR, 'buckets'))
 class ObjectStoreTestCase(test.BaseTestCase):
     """Test objectstore API directly."""
 
-    def setUp(self): # pylint: disable-msg=C0103
+    def setUp(self): # pylint: disable=C0103
         """Setup users and projects."""
         super(ObjectStoreTestCase, self).setUp()
         self.flags(buckets_path=os.path.join(OSS_TEMPDIR, 'buckets'),
@@ -78,7 +78,7 @@ class ObjectStoreTestCase(test.BaseTestCase):
 
         self.context = Context()
 
-    def tearDown(self): # pylint: disable-msg=C0103
+    def tearDown(self): # pylint: disable=C0103
         """Tear down users and projects."""
         self.auth_manager.delete_project('proj1')
         self.auth_manager.delete_project('proj2')
@@ -168,7 +168,7 @@ class ObjectStoreTestCase(test.BaseTestCase):
 class TestHTTPChannel(http.HTTPChannel):
     """Dummy site required for twisted.web"""
 
-    def checkPersistence(self, _, __): # pylint: disable-msg=C0103
+    def checkPersistence(self, _, __): # pylint: disable=C0103
         """Otherwise we end up with an unclean reactor."""
         return False
 
@@ -181,7 +181,7 @@ class TestSite(server.Site):
 class S3APITestCase(test.TrialTestCase):
     """Test objectstore through S3 API."""
 
-    def setUp(self): # pylint: disable-msg=C0103
+    def setUp(self): # pylint: disable=C0103
         """Setup users, projects, and start a test server."""
         super(S3APITestCase, self).setUp()
 
@@ -198,7 +198,7 @@ class S3APITestCase(test.TrialTestCase):
 
         root = S3()
         self.site = TestSite(root)
-        # pylint: disable-msg=E1101
+        # pylint: disable=E1101
         self.listening_port = reactor.listenTCP(0, self.site,
                                                 interface='127.0.0.1')
         # pylint: enable-msg=E1101
@@ -221,11 +221,11 @@ class S3APITestCase(test.TrialTestCase):
 
         self.conn.get_http_connection = get_http_connection
 
-    def _ensure_no_buckets(self, buckets): # pylint: disable-msg=C0111
+    def _ensure_no_buckets(self, buckets): # pylint: disable=C0111
         self.assertEquals(len(buckets), 0, "Bucket list was not empty")
         return True
 
-    def _ensure_one_bucket(self, buckets, name): # pylint: disable-msg=C0111
+    def _ensure_one_bucket(self, buckets, name): # pylint: disable=C0111
         self.assertEquals(len(buckets), 1,
                           "Bucket list didn't have exactly one element in it")
         self.assertEquals(buckets[0].name, name, "Wrong name")
@@ -296,7 +296,7 @@ class S3APITestCase(test.TrialTestCase):
         deferred.addCallback(self._ensure_no_buckets)
         return deferred
 
-    def tearDown(self): # pylint: disable-msg=C0103
+    def tearDown(self): # pylint: disable=C0103
         """Tear down auth and test server."""
         self.auth_manager.delete_user('admin')
         self.auth_manager.delete_project('admin')
-- 
cgit 


From b380e4a93f6d8ebc772c3989d27f9549b730eee5 Mon Sep 17 00:00:00 2001
From: Michael Gundlach <michael.gundlach@rackspace.com>
Date: Wed, 18 Aug 2010 11:44:24 -0400
Subject: Changed our minds: keep pylint equal to Ubuntu Lucid version, and use
 disable-msg throughout.

---
 nova/network/linux_net.py          |  4 ++--
 nova/network/model.py              |  8 ++++----
 nova/network/service.py            |  2 +-
 nova/network/vpn.py                |  2 +-
 nova/rpc.py                        |  8 ++++----
 nova/test.py                       | 10 +++++-----
 nova/tests/network_unittest.py     |  4 ++--
 nova/tests/objectstore_unittest.py | 16 ++++++++--------
 nova/tests/rpc_unittest.py         |  2 +-
 nova/wsgi.py                       |  4 ++--
 10 files changed, 30 insertions(+), 30 deletions(-)

(limited to 'nova')

diff --git a/nova/network/linux_net.py b/nova/network/linux_net.py
index a5014b2cb..9e5aabd97 100644
--- a/nova/network/linux_net.py
+++ b/nova/network/linux_net.py
@@ -154,7 +154,7 @@ def start_dnsmasq(network):
         try:
             os.kill(pid, signal.SIGHUP)
             return
-        except Exception as exc:  # pylint: disable=W0703
+        except Exception as exc:  # pylint: disable-msg=W0703
             logging.debug("Hupping dnsmasq threw %s", exc)
 
     # FLAGFILE and DNSMASQ_INTERFACE in env
@@ -170,7 +170,7 @@ def stop_dnsmasq(network):
     if pid:
         try:
             os.kill(pid, signal.SIGTERM)
-        except Exception as exc:  # pylint: disable=W0703
+        except Exception as exc:  # pylint: disable-msg=W0703
             logging.debug("Killing dnsmasq threw %s", exc)
 
 
diff --git a/nova/network/model.py b/nova/network/model.py
index d3a6a6552..6e4fcc47e 100644
--- a/nova/network/model.py
+++ b/nova/network/model.py
@@ -59,7 +59,7 @@ logging.getLogger().setLevel(logging.DEBUG)
 
 class Vlan(datastore.BasicModel):
     """Tracks vlans assigned to project it the datastore"""
-    def __init__(self, project, vlan):  # pylint: disable=W0231
+    def __init__(self, project, vlan):  # pylint: disable-msg=W0231
         """
         Since we don't want to try and find a vlan by its identifier,
         but by a project id, we don't call super-init.
@@ -161,7 +161,7 @@ class FixedIp(datastore.BasicModel):
                 'state': 'none'}
 
     @classmethod
-    # pylint: disable=R0913
+    # pylint: disable-msg=R0913
     def create(cls, user_id, project_id, address, mac, hostname, network_id):
         """Creates an FixedIp object"""
         addr = cls(address)
@@ -215,7 +215,7 @@ class BaseNetwork(datastore.BasicModel):
         return {'network_id': self.network_id, 'network_str': self.network_str}
 
     @classmethod
-    # pylint: disable=R0913
+    # pylint: disable-msg=R0913
     def create(cls, user_id, project_id, security_group, vlan, network_str):
         """Create a BaseNetwork object"""
         network_id = "%s:%s" % (project_id, security_group)
@@ -268,7 +268,7 @@ class BaseNetwork(datastore.BasicModel):
         """Returns the project associated with this network"""
         return manager.AuthManager().get_project(self['project_id'])
 
-    # pylint: disable=R0913
+    # pylint: disable-msg=R0913
     def _add_host(self, user_id, project_id, ip_address, mac, hostname):
         """Add a host to the datastore"""
         self.address_class.create(user_id, project_id, ip_address,
diff --git a/nova/network/service.py b/nova/network/service.py
index da102a056..d3aa1c46f 100644
--- a/nova/network/service.py
+++ b/nova/network/service.py
@@ -195,7 +195,7 @@ class VlanNetworkService(BaseNetworkService):
     #             simplified and improved.  Also there it may be useful
     #             to support vlans separately from dhcp, instead of having
     #             both of them together in this class.
-    # pylint: disable=W0221
+    # pylint: disable-msg=W0221
     def allocate_fixed_ip(self,
                           user_id,
                           project_id,
diff --git a/nova/network/vpn.py b/nova/network/vpn.py
index cf2579e61..85366ed89 100644
--- a/nova/network/vpn.py
+++ b/nova/network/vpn.py
@@ -105,7 +105,7 @@ class NetworkData(datastore.BasicModel):
         return datastore.Redis.instance().scard('ip:%s:ports' % vpn_ip)
 
     @property
-    def ip(self):  # pylint: disable=C0103
+    def ip(self):  # pylint: disable-msg=C0103
         """The ip assigned to the project"""
         return self['ip']
 
diff --git a/nova/rpc.py b/nova/rpc.py
index 824a66b5b..84a9b5590 100644
--- a/nova/rpc.py
+++ b/nova/rpc.py
@@ -59,7 +59,7 @@ class Connection(carrot_connection.BrokerConnection):
                 params['backend_cls'] = fakerabbit.Backend
 
             # NOTE(vish): magic is fun!
-            # pylint: disable=W0142
+            # pylint: disable-msg=W0142
             cls._instance = cls(**params)
         return cls._instance
 
@@ -104,7 +104,7 @@ class Consumer(messaging.Consumer):
             if self.failed_connection:
                 # NOTE(vish): conn is defined in the parent class, we can
                 #             recreate it as long as we create the backend too
-                # pylint: disable=W0201
+                # pylint: disable-msg=W0201
                 self.conn = Connection.recreate()
                 self.backend = self.conn.create_backend()
             super(Consumer, self).fetch(no_ack, auto_ack, enable_callbacks)
@@ -114,7 +114,7 @@ class Consumer(messaging.Consumer):
         # NOTE(vish): This is catching all errors because we really don't
         #             exceptions to be logged 10 times a second if some
         #             persistent failure occurs.
-        except Exception:  # pylint: disable=W0703
+        except Exception:  # pylint: disable-msg=W0703
             if not self.failed_connection:
                 logging.exception("Failed to fetch message from queue")
                 self.failed_connection = True
@@ -178,7 +178,7 @@ class AdapterConsumer(TopicConsumer):
         node_func = getattr(self.proxy, str(method))
         node_args = dict((str(k), v) for k, v in args.iteritems())
         # NOTE(vish): magic is fun!
-        # pylint: disable=W0142
+        # pylint: disable-msg=W0142
         d = defer.maybeDeferred(node_func, **node_args)
         if msg_id:
             d.addCallback(lambda rval: msg_reply(msg_id, rval, None))
diff --git a/nova/test.py b/nova/test.py
index a75e0de1a..c392c8a84 100644
--- a/nova/test.py
+++ b/nova/test.py
@@ -53,7 +53,7 @@ def skip_if_fake(func):
 
 class TrialTestCase(unittest.TestCase):
     """Test case base class for all unit tests"""
-    def setUp(self): # pylint: disable=C0103
+    def setUp(self): # pylint: disable-msg=C0103
         """Run before each test method to initialize test environment"""
         super(TrialTestCase, self).setUp()
 
@@ -63,7 +63,7 @@ class TrialTestCase(unittest.TestCase):
         self.stubs = stubout.StubOutForTesting()
         self.flag_overrides = {}
 
-    def tearDown(self): # pylint: disable=C0103
+    def tearDown(self): # pylint: disable-msg=C0103
         """Runs after each test method to finalize/tear down test environment"""
         super(TrialTestCase, self).tearDown()
         self.reset_flags()
@@ -94,7 +94,7 @@ class TrialTestCase(unittest.TestCase):
 class BaseTestCase(TrialTestCase):
     # TODO(jaypipes): Can this be moved into the TrialTestCase class?
     """Base test case class for all unit tests."""
-    def setUp(self): # pylint: disable=C0103
+    def setUp(self): # pylint: disable-msg=C0103
         """Run before each test method to initialize test environment"""
         super(BaseTestCase, self).setUp()
         # TODO(termie): we could possibly keep a more global registry of
@@ -106,7 +106,7 @@ class BaseTestCase(TrialTestCase):
         self._done_waiting = False
         self._timed_out = False
 
-    def tearDown(self):# pylint: disable=C0103
+    def tearDown(self):# pylint: disable-msg=C0103
         """Runs after each test method to finalize/tear down test environment"""
         super(BaseTestCase, self).tearDown()
         for x in self.injected:
@@ -137,7 +137,7 @@ class BaseTestCase(TrialTestCase):
         if self._waiting:
             try:
                 self.ioloop.remove_timeout(self._waiting)
-            except Exception: # pylint: disable=W0703
+            except Exception: # pylint: disable-msg=W0703
                 # TODO(jaypipes): This produces a pylint warning.  Should
                 # we really be catching Exception and then passing here?
                 pass
diff --git a/nova/tests/network_unittest.py b/nova/tests/network_unittest.py
index 039509809..993bfacc2 100644
--- a/nova/tests/network_unittest.py
+++ b/nova/tests/network_unittest.py
@@ -36,7 +36,7 @@ FLAGS = flags.FLAGS
 
 class NetworkTestCase(test.TrialTestCase):
     """Test cases for network code"""
-    def setUp(self):  # pylint: disable=C0103
+    def setUp(self):  # pylint: disable-msg=C0103
         super(NetworkTestCase, self).setUp()
         # NOTE(vish): if you change these flags, make sure to change the
         #             flags in the corresponding section in nova-dhcpbridge
@@ -60,7 +60,7 @@ class NetworkTestCase(test.TrialTestCase):
             vpn.NetworkData.create(self.projects[i].id)
         self.service = service.VlanNetworkService()
 
-    def tearDown(self):  # pylint: disable=C0103
+    def tearDown(self):  # pylint: disable-msg=C0103
         super(NetworkTestCase, self).tearDown()
         for project in self.projects:
             self.manager.delete_project(project)
diff --git a/nova/tests/objectstore_unittest.py b/nova/tests/objectstore_unittest.py
index 5b956fccf..dece4b5d5 100644
--- a/nova/tests/objectstore_unittest.py
+++ b/nova/tests/objectstore_unittest.py
@@ -56,7 +56,7 @@ os.makedirs(os.path.join(OSS_TEMPDIR, 'buckets'))
 class ObjectStoreTestCase(test.BaseTestCase):
     """Test objectstore API directly."""
 
-    def setUp(self): # pylint: disable=C0103
+    def setUp(self): # pylint: disable-msg=C0103
         """Setup users and projects."""
         super(ObjectStoreTestCase, self).setUp()
         self.flags(buckets_path=os.path.join(OSS_TEMPDIR, 'buckets'),
@@ -78,7 +78,7 @@ class ObjectStoreTestCase(test.BaseTestCase):
 
         self.context = Context()
 
-    def tearDown(self): # pylint: disable=C0103
+    def tearDown(self): # pylint: disable-msg=C0103
         """Tear down users and projects."""
         self.auth_manager.delete_project('proj1')
         self.auth_manager.delete_project('proj2')
@@ -168,7 +168,7 @@ class ObjectStoreTestCase(test.BaseTestCase):
 class TestHTTPChannel(http.HTTPChannel):
     """Dummy site required for twisted.web"""
 
-    def checkPersistence(self, _, __): # pylint: disable=C0103
+    def checkPersistence(self, _, __): # pylint: disable-msg=C0103
         """Otherwise we end up with an unclean reactor."""
         return False
 
@@ -181,7 +181,7 @@ class TestSite(server.Site):
 class S3APITestCase(test.TrialTestCase):
     """Test objectstore through S3 API."""
 
-    def setUp(self): # pylint: disable=C0103
+    def setUp(self): # pylint: disable-msg=C0103
         """Setup users, projects, and start a test server."""
         super(S3APITestCase, self).setUp()
 
@@ -198,7 +198,7 @@ class S3APITestCase(test.TrialTestCase):
 
         root = S3()
         self.site = TestSite(root)
-        # pylint: disable=E1101
+        # pylint: disable-msg=E1101
         self.listening_port = reactor.listenTCP(0, self.site,
                                                 interface='127.0.0.1')
         # pylint: enable-msg=E1101
@@ -221,11 +221,11 @@ class S3APITestCase(test.TrialTestCase):
 
         self.conn.get_http_connection = get_http_connection
 
-    def _ensure_no_buckets(self, buckets): # pylint: disable=C0111
+    def _ensure_no_buckets(self, buckets): # pylint: disable-msg=C0111
         self.assertEquals(len(buckets), 0, "Bucket list was not empty")
         return True
 
-    def _ensure_one_bucket(self, buckets, name): # pylint: disable=C0111
+    def _ensure_one_bucket(self, buckets, name): # pylint: disable-msg=C0111
         self.assertEquals(len(buckets), 1,
                           "Bucket list didn't have exactly one element in it")
         self.assertEquals(buckets[0].name, name, "Wrong name")
@@ -296,7 +296,7 @@ class S3APITestCase(test.TrialTestCase):
         deferred.addCallback(self._ensure_no_buckets)
         return deferred
 
-    def tearDown(self): # pylint: disable=C0103
+    def tearDown(self): # pylint: disable-msg=C0103
         """Tear down auth and test server."""
         self.auth_manager.delete_user('admin')
         self.auth_manager.delete_project('admin')
diff --git a/nova/tests/rpc_unittest.py b/nova/tests/rpc_unittest.py
index 764a97416..e12a28fbc 100644
--- a/nova/tests/rpc_unittest.py
+++ b/nova/tests/rpc_unittest.py
@@ -32,7 +32,7 @@ FLAGS = flags.FLAGS
 
 class RpcTestCase(test.BaseTestCase):
     """Test cases for rpc"""
-    def setUp(self):  # pylint: disable=C0103
+    def setUp(self):  # pylint: disable-msg=C0103
         super(RpcTestCase, self).setUp()
         self.conn = rpc.Connection.instance()
         self.receiver = TestReceiver()
diff --git a/nova/wsgi.py b/nova/wsgi.py
index a0a175dc7..fd87afe6e 100644
--- a/nova/wsgi.py
+++ b/nova/wsgi.py
@@ -83,7 +83,7 @@ class Application(object):
         raise NotImplementedError("You must implement __call__")
 
 
-class Middleware(Application): # pylint: disable=W0223
+class Middleware(Application): # pylint: disable-msg=W0223
     """
     Base WSGI middleware wrapper. These classes require an application to be
     initialized that will be called next.  By default the middleware will
@@ -91,7 +91,7 @@ class Middleware(Application): # pylint: disable=W0223
     behavior.
     """
 
-    def __init__(self, application): # pylint: disable=W0231
+    def __init__(self, application): # pylint: disable-msg=W0231
         self.application = application
 
     @webob.dec.wsgify
-- 
cgit