From c27312c2efb31b9ec88f5635029f9d2dc8667b50 Mon Sep 17 00:00:00 2001 From: Yosef Berman Date: Thu, 20 Sep 2012 15:09:17 -0700 Subject: Fixes to the SolarisISCSI Driver Even when the san_is_local config option was set to false, the SolarisISCSIDriver's _execute method was accidentally set to util.execute by the VolumeDriver's __init__ method. Fix bug 1053041 Change-Id: Ifd8436874759d75633da3dbbfa01bd99f979ddea --- nova/volume/san.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'nova/volume') diff --git a/nova/volume/san.py b/nova/volume/san.py index d604cfffd..e5faa2b63 100644 --- a/nova/volume/san.py +++ b/nova/volume/san.py @@ -86,8 +86,8 @@ class SanISCSIDriver(nova.volume.driver.ISCSIDriver): remote protocol. """ - def __init__(self): - super(SanISCSIDriver, self).__init__() + def __init__(self, *args, **kwargs): + super(SanISCSIDriver, self).__init__(*args, **kwargs) self.run_local = FLAGS.san_is_local def _build_iscsi_target_name(self, volume): @@ -120,7 +120,7 @@ class SanISCSIDriver(nova.volume.driver.ISCSIDriver): return utils.execute(*cmd, **kwargs) else: check_exit_code = kwargs.pop('check_exit_code', None) - command = ' '.join(*cmd) + command = ' '.join(cmd) return self._run_ssh(command, check_exit_code) def _run_ssh(self, command, check_exit_code=True): @@ -211,9 +211,8 @@ class SolarisISCSIDriver(SanISCSIDriver): def _execute(self, *cmd, **kwargs): new_cmd = ['pfexec'] - new_cmd.extend(*cmd) - return super(SolarisISCSIDriver, self)._execute(self, - *new_cmd, + new_cmd.extend(cmd) + return super(SolarisISCSIDriver, self)._execute(*new_cmd, **kwargs) def _view_exists(self, luid): -- cgit