From 88ccade9d5700db881f2ffc53e4a48a76e92c2db Mon Sep 17 00:00:00 2001 From: lzyeval Date: Sat, 31 Dec 2011 12:23:56 +0800 Subject: PEP8 type comparison cleanup Fixes bug #910295 The None, True, and False values are singletons. All variable *comparisons* to singletons should use 'is' or 'is not'. All variable *evaluations* to boolean should use 'if' or 'if not'. "== None", "== True", "== False", and "!= None" comparisons in sqlalchemy's where(), or_(), filter(), and_(), and select() functions should not be changed. Incorrect comparisons or evaluations in comments were not changed. Change-Id: I087f0883bf115b5fe714ccfda86a794b9b2a87f7 --- nova/volume/api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'nova/volume/api.py') diff --git a/nova/volume/api.py b/nova/volume/api.py index b4d5ac48d..1cfe8a3b6 100644 --- a/nova/volume/api.py +++ b/nova/volume/api.py @@ -42,7 +42,7 @@ class API(base.Base): def create(self, context, size, snapshot_id, name, description, volume_type=None, metadata=None, availability_zone=None): - if snapshot_id != None: + if snapshot_id is not None: snapshot = self.get_snapshot(context, snapshot_id) if snapshot['status'] != "available": raise exception.ApiError( -- cgit