From c1e5e3352a71cc61ba9e7dba0d9048d8b766e2c0 Mon Sep 17 00:00:00 2001 From: Nikola Dipanov Date: Wed, 10 Oct 2012 13:47:26 +0200 Subject: Fixes test_libvirtr spawn_with_network_info test This patch fixes the LibvirtConnTestCase.test_spawn_with_network_info test case that was reported as bug 1053572. The new implementation of the test makes no assumptions about the raised exceptions, and exercises the LibvirtDriver.spawn method completely. The test has the network_info faked and the libvirt connection mocked out. In addition. it also fixes the fake_network.FakeVIFDriver class used in this test to return a LibvirtConfigGuestInterface instance with fake values instead of just a dict. Also fixes some docstring inaccuracies in the nova.libvirt.vif module that may have lead to the FakeVIFDrivers wrong implementation before. Fixes bug 1053572 Change-Id: Ie5b69a2269ab099267231329eae21bd308fef835 --- nova/virt/libvirt/vif.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'nova/virt') diff --git a/nova/virt/libvirt/vif.py b/nova/virt/libvirt/vif.py index ea0834d87..b4eee39b3 100644 --- a/nova/virt/libvirt/vif.py +++ b/nova/virt/libvirt/vif.py @@ -52,7 +52,7 @@ class LibvirtBridgeDriver(vif.VIFDriver): """VIF driver for Linux bridge.""" def _get_configurations(self, instance, network, mapping): - """Get a dictionary of VIF configurations for bridge type.""" + """Get VIF configurations for bridge type.""" mac_id = mapping['mac'].replace(':', '') -- cgit