From bbee6536d98f0ad7e20f302ff1936cfb9cda0c2c Mon Sep 17 00:00:00 2001 From: Mate Lakat Date: Mon, 29 Oct 2012 13:51:34 +0000 Subject: refactor: extract method: connect_volume Related to blueprint xenapi-volume-drivers Extract connect_volume call from attach_volume, and a test for attach_volume. By extracting this call, it will be easier to implement other drivers, by providing an alternate implementation for this extracted method. Change-Id: Ie5a17ec7fada26a9df5ba8a29ed0dadeb02516e8 --- nova/virt/xenapi/volumeops.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'nova/virt') diff --git a/nova/virt/xenapi/volumeops.py b/nova/virt/xenapi/volumeops.py index c44e38f92..ae21518d8 100644 --- a/nova/virt/xenapi/volumeops.py +++ b/nova/virt/xenapi/volumeops.py @@ -113,6 +113,7 @@ class VolumeOps(object): # NOTE: No Resource Pool concept so far LOG.debug(_("Attach_volume: %(connection_info)s, %(instance_name)s," " %(mountpoint)s") % locals()) + driver_type = connection_info['driver_volume_type'] if driver_type not in ['iscsi', 'xensm']: raise exception.VolumeDriverNotFound(driver_type=driver_type) @@ -120,6 +121,15 @@ class VolumeOps(object): connection_data = connection_info['data'] dev_number = volume_utils.get_device_number(mountpoint) + self.connect_volume( + connection_data, dev_number, instance_name, vm_ref) + + LOG.info(_('Mountpoint %(mountpoint)s attached to' + ' instance %(instance_name)s') % locals()) + + def connect_volume(self, connection_data, dev_number, instance_name, + vm_ref): + if 'name_label' not in connection_data: label = 'tempSR-%s' % connection_data['volume_id'] else: @@ -131,7 +141,6 @@ class VolumeOps(object): else: desc = connection_data['name_description'] - LOG.debug(connection_info) sr_params = {} if u'sr_uuid' not in connection_data: sr_params = volume_utils.parse_volume_info(connection_data) @@ -190,9 +199,6 @@ class VolumeOps(object): raise Exception(_('Unable to attach volume to instance %s') % instance_name) - LOG.info(_('Mountpoint %(mountpoint)s attached to' - ' instance %(instance_name)s') % locals()) - def detach_volume(self, connection_info, instance_name, mountpoint): """Detach volume storage to VM instance""" -- cgit