From 795d1bcfd13aae2d07f52a2a1a51117e78a234c8 Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Fri, 1 Feb 2013 03:29:01 -0500 Subject: Tweakify is_valid_boolstr(). This function used a few backslashes for continuation. According to HACKING, we prefer to not use this. This code gets rid of them by changing the way the checks are done. Look at those backslashes ... sitting there at the end of the line. It's like they're looking down on the code that precedes them, as if they are somehow superior to the other characters. Banish them from this utility function! Also add a unit test for this code. Part of greenprint bored-on-an-airplane. Change-Id: If88b6e63ab078916ce1b9cf2f5e99623c402996c --- nova/utils.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'nova/utils.py') diff --git a/nova/utils.py b/nova/utils.py index 83bf55583..be441bfcc 100644 --- a/nova/utils.py +++ b/nova/utils.py @@ -876,11 +876,8 @@ def is_int_like(val): def is_valid_boolstr(val): """Check if the provided string is a valid bool string or not.""" - val = str(val).lower() - return val == 'true' or val == 'false' or \ - val == 'yes' or val == 'no' or \ - val == 'y' or val == 'n' or \ - val == '1' or val == '0' + boolstrs = ('true', 'false', 'yes', 'no', 'y', 'n', '1', '0') + return str(val).lower() in boolstrs def is_valid_ipv4(address): -- cgit