From 4d350dc82ecfe1d272bfbd43445a78c69a32fc90 Mon Sep 17 00:00:00 2001
From: Michael Still <mikal@stillhq.com>
Date: Sat, 11 Aug 2012 20:51:27 +1000
Subject: Simple checks for instance user data.

Check that instance user data wont be truncated, and that it is
valid base64 data. This partially resolves bug 1035055. I don't
love the hard coded maximum length, but I haven't worked out how
to get sqlalchemy to tell me the maximum size of the data type.

Change-Id: I045d6b4481563d01cae371cf61a91781cfed6f4b
---
 nova/tests/compute/test_compute.py | 49 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

(limited to 'nova/tests')

diff --git a/nova/tests/compute/test_compute.py b/nova/tests/compute/test_compute.py
index a625397ea..10cc325e5 100644
--- a/nova/tests/compute/test_compute.py
+++ b/nova/tests/compute/test_compute.py
@@ -18,6 +18,7 @@
 #    under the License.
 """Tests for compute service"""
 
+import base64
 import copy
 import datetime
 import functools
@@ -2364,6 +2365,54 @@ class ComputeAPITestCase(BaseTestCase):
         self.assertEqual(pre_build_len,
                          len(db.instance_get_all(context.get_admin_context())))
 
+    def test_create_with_large_user_data(self):
+        """Test an instance type with too much user data."""
+
+        inst_type = instance_types.get_default_instance_type()
+
+        def fake_show(*args):
+            img = copy.copy(self.fake_image)
+            img['min_ram'] = 2
+            return img
+        self.stubs.Set(fake_image._FakeImageService, 'show', fake_show)
+
+        self.assertRaises(exception.InstanceUserDataTooLarge,
+            self.compute_api.create, self.context, inst_type, None,
+                          user_data=('1' * 65536))
+
+    def test_create_with_malformed_user_data(self):
+        """Test an instance type with malformed user data."""
+
+        inst_type = instance_types.get_default_instance_type()
+
+        def fake_show(*args):
+            img = copy.copy(self.fake_image)
+            img['min_ram'] = 2
+            return img
+        self.stubs.Set(fake_image._FakeImageService, 'show', fake_show)
+
+        self.assertRaises(exception.InstanceUserDataMalformed,
+            self.compute_api.create, self.context, inst_type, None,
+                          user_data='banana')
+
+    def test_create_with_base64_user_data(self):
+        """Test an instance type with ok much user data."""
+
+        inst_type = instance_types.get_default_instance_type()
+
+        def fake_show(*args):
+            img = copy.copy(self.fake_image)
+            img['min_ram'] = 2
+            return img
+        self.stubs.Set(fake_image._FakeImageService, 'show', fake_show)
+
+        # NOTE(mikal): a string of length 48510 encodes to 65532 characters of
+        # base64
+        (refs, resv_id) = self.compute_api.create(
+            self.context, inst_type, None,
+            user_data=base64.encodestring('1' * 48510))
+        db.instance_destroy(self.context, refs[0]['uuid'])
+
     def test_default_hostname_generator(self):
         fake_uuids = [str(utils.gen_uuid()) for x in xrange(4)]
 
-- 
cgit