From 5f7b253fa6db2a8a40d3cc0dd34f16e4281b5937 Mon Sep 17 00:00:00 2001 From: Mark McLoughlin Date: Thu, 23 Aug 2012 11:22:59 +0100 Subject: Re-work the handling of firewall_driver default Fixes bug #1040430 We have a different default firewall driver for libvirt and xenapi, yet the sample config file currently contains: firewall_driver=nova.virt.firewall.IptablesFirewallDriver In the case of libvirt, it should actually be: firewall_driver=nova.virt.firewall.libvirt.IptablesFirewallDriver This is really easy for users to get confused about. Since we don't have a different sample config file for each hypervisor, the best we can do is to just not include the default in the sample config and have each hypervisor supply its default at runtime. DocImpact: update nova.conf docs Change-Id: Ie78371bcceac5a65978d695934e0246022f748a3 --- nova/tests/test_virt_drivers.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'nova/tests') diff --git a/nova/tests/test_virt_drivers.py b/nova/tests/test_virt_drivers.py index aaae975a4..f64270b1a 100644 --- a/nova/tests/test_virt_drivers.py +++ b/nova/tests/test_virt_drivers.py @@ -77,8 +77,7 @@ class _FakeDriverBackendTestCase(test.TestCase): nova.virt.libvirt.driver.libvirt_utils = fake_libvirt_utils nova.virt.libvirt.firewall.libvirt = fakelibvirt - self.flags(firewall_driver=nova.virt.libvirt.firewall.drivers[0], - rescue_image_id="2", + self.flags(rescue_image_id="2", rescue_kernel_id="3", rescue_ramdisk_id=None, libvirt_snapshots_directory='./') -- cgit