From e91c3d141c957485dcb66c73e84b41b775e4268b Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Mon, 17 Jun 2013 15:05:17 -0700 Subject: Make NovaObject support extra attributes in items() An object could define a field as a property, which needs to get included in items() and iteritems() for dict compatibility. Related to blueprint unified-object-model Change-Id: I2ca665e70fc6d3c9664ae7a74dffd99a56f6a8c1 --- nova/objects/base.py | 6 ++++-- nova/objects/instance.py | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) (limited to 'nova/objects') diff --git a/nova/objects/base.py b/nova/objects/base.py index 2e0797477..b6071779f 100644 --- a/nova/objects/base.py +++ b/nova/objects/base.py @@ -182,6 +182,7 @@ class NovaObject(object): 'deleted_at': obj_utils.datetime_or_str_or_none, 'deleted': bool, } + obj_extra_fields = [] def __init__(self): self._changed_fields = set() @@ -330,8 +331,9 @@ class NovaObject(object): NOTE(danms): May be removed in the future. """ - for name in self.fields: - if hasattr(self, get_attrname(name)): + for name in self.fields.keys() + self.obj_extra_fields: + if (hasattr(self, get_attrname(name)) or + name in self.obj_extra_fields): yield name, getattr(self, name) items = lambda self: list(self.iteritems()) diff --git a/nova/objects/instance.py b/nova/objects/instance.py index aec6fe968..592206476 100644 --- a/nova/objects/instance.py +++ b/nova/objects/instance.py @@ -110,6 +110,8 @@ class Instance(base.NovaObject): } + obj_extra_fields = ['name'] + @property def name(self): try: -- cgit