From f0d5df523b982ef1737dc0ee2e698b13041af64c Mon Sep 17 00:00:00 2001
From: Johannes Erdfelt <johannes.erdfelt@rackspace.com>
Date: Tue, 28 Feb 2012 05:54:48 +0000
Subject: Add utils.tempdir() context manager for easy temp dirs

Fixes bug 883323 (and others)

Users of tempfile.mkdtemp() need to make sure the directory is cleaned
up when it's done being used. Unfortunately, not all of the code does
so at all, or safely (by using a try/finally block).

Change-Id: I270109d83efec4f8b3dd954021493f4d96c6ab79
---
 nova/compat/flagfile.py | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'nova/compat')

diff --git a/nova/compat/flagfile.py b/nova/compat/flagfile.py
index 8721d3485..02d571cbf 100644
--- a/nova/compat/flagfile.py
+++ b/nova/compat/flagfile.py
@@ -175,6 +175,8 @@ def handle_flagfiles_managed(args):
              # Do stuff
         # Any temporary fils have been removed
     '''
+    # NOTE(johannes): Would be nice to use utils.tempdir(), but it
+    # causes an import loop
     tempdir = tempfile.mkdtemp(prefix='nova-conf-')
     try:
         yield handle_flagfiles(args, tempdir=tempdir)
-- 
cgit