From cefc979a001d82cca6ddfa1fd1abea698be458b7 Mon Sep 17 00:00:00 2001 From: Johannes Erdfelt Date: Thu, 26 Jan 2012 23:23:04 +0000 Subject: Add a note explaining why unhandled exceptions shouldn't be returned to users. For future developers so they don't re-introduce a bug by accident. Change-Id: I24f03adcc795db6252be988c076043bb74026733 --- nova/api/openstack/__init__.py | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'nova/api') diff --git a/nova/api/openstack/__init__.py b/nova/api/openstack/__init__.py index 240bf0d80..e48f5c686 100644 --- a/nova/api/openstack/__init__.py +++ b/nova/api/openstack/__init__.py @@ -42,6 +42,10 @@ class FaultWrapper(base_wsgi.Middleware): except Exception as ex: LOG.exception(_("Caught error: %s"), unicode(ex)) exc = webob.exc.HTTPInternalServerError() + # NOTE(johannes): We leave the explanation empty here on + # purpose. It could possibly have sensitive information + # that should not be returned back to the user. See + # bugs 868360 and 874472 return wsgi.Fault(exc) -- cgit