From 98b8001407ef06e1cdb8434571288dc56dba7bc0 Mon Sep 17 00:00:00 2001 From: Alex Meade Date: Wed, 18 Apr 2012 17:39:58 -0400 Subject: Make rebuilds with an emtpy name raise BadRequest. Fixes bug 973591 Change-Id: I87f189175c55a6922e7277857b85d526b9bfa6e1 --- nova/api/openstack/compute/servers.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'nova/api') diff --git a/nova/api/openstack/compute/servers.py b/nova/api/openstack/compute/servers.py index 2e7b184c4..26c3b020a 100644 --- a/nova/api/openstack/compute/servers.py +++ b/nova/api/openstack/compute/servers.py @@ -271,7 +271,10 @@ class ActionDeserializer(CommonDeserializer): def _action_rebuild(self, node): rebuild = {} if node.hasAttribute("name"): - rebuild['name'] = node.getAttribute("name") + name = node.getAttribute("name") + if not name: + raise AttributeError("Name cannot be blank") + rebuild['name'] = name if node.hasAttribute("auto_disk_config"): rebuild['auto_disk_config'] = node.getAttribute("auto_disk_config") -- cgit