From 6c92e3c7885c1eb7da3032862a30a10348b2d810 Mon Sep 17 00:00:00 2001 From: Joe Gordon Date: Mon, 10 Dec 2012 18:41:21 +0200 Subject: Access DB values as dict not as attributes. Part 4 We cannot assume nova.db.api will be returning sqlalchemy objects attributes, instead treat return values as dicts Part of blueprint db-api-cleanup Change-Id: Ie98c2cad080d95edcfa89b2601f6c57cb1188cbc --- nova/api/ec2/cloud.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) (limited to 'nova/api') diff --git a/nova/api/ec2/cloud.py b/nova/api/ec2/cloud.py index ab59205a9..8155efb10 100644 --- a/nova/api/ec2/cloud.py +++ b/nova/api/ec2/cloud.py @@ -484,14 +484,14 @@ class CloudController(object): r = {} r['groups'] = [] r['ipRanges'] = [] - if rule.group_id: - source_group = rule.grantee_group - r['groups'] += [{'groupName': source_group.name, - 'userId': source_group.project_id}] - if rule.protocol: - r['ipProtocol'] = rule.protocol.lower() - r['fromPort'] = rule.from_port - r['toPort'] = rule.to_port + if rule['group_id']: + source_group = rule['grantee_group'] + r['groups'] += [{'groupName': source_group['name'], + 'userId': source_group['project_id']}] + if rule['protocol']: + r['ipProtocol'] = rule['protocol'].lower() + r['fromPort'] = rule['from_port'] + r['toPort'] = rule['to_port'] g['ipPermissions'] += [dict(r)] else: for protocol, min_port, max_port in (('icmp', -1, -1), @@ -502,10 +502,10 @@ class CloudController(object): r['toPort'] = max_port g['ipPermissions'] += [dict(r)] else: - r['ipProtocol'] = rule.protocol - r['fromPort'] = rule.from_port - r['toPort'] = rule.to_port - r['ipRanges'] += [{'cidrIp': rule.cidr}] + r['ipProtocol'] = rule['protocol'] + r['fromPort'] = rule['from_port'] + r['toPort'] = rule['to_port'] + r['ipRanges'] += [{'cidrIp': rule['cidr']}] g['ipPermissions'] += [r] return g -- cgit