From e7787ab9c2042bb3b4f28189f7f075638c72db98 Mon Sep 17 00:00:00 2001 From: Michael Still Date: Thu, 13 Jun 2013 17:06:57 +1000 Subject: Remove use of locals() in db migrations. This isn't logging usage, but I still feel that something more explicit is safer. Let's not try to be too clever. Change-Id: I40633283dbdced6d69eb78e22a04eeb6957c0841 --- .../sqlalchemy/migrate_repo/versions/149_inet_datatype_for_postgres.py | 2 +- nova/db/sqlalchemy/migrate_repo/versions/156_cidr_column_length.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/nova/db/sqlalchemy/migrate_repo/versions/149_inet_datatype_for_postgres.py b/nova/db/sqlalchemy/migrate_repo/versions/149_inet_datatype_for_postgres.py index 79ad6f014..c837f59f0 100644 --- a/nova/db/sqlalchemy/migrate_repo/versions/149_inet_datatype_for_postgres.py +++ b/nova/db/sqlalchemy/migrate_repo/versions/149_inet_datatype_for_postgres.py @@ -54,7 +54,7 @@ def upgrade(migrate_engine): migrate_engine.execute( "ALTER TABLE %(table)s " "ALTER COLUMN %(column)s TYPE INET USING %(column)s::INET" - % locals()) + % {'table': table, 'column': column}) else: for table, column in TABLE_COLUMNS: t = Table(table, meta, autoload=True) diff --git a/nova/db/sqlalchemy/migrate_repo/versions/156_cidr_column_length.py b/nova/db/sqlalchemy/migrate_repo/versions/156_cidr_column_length.py index fda0c5075..e0425d675 100644 --- a/nova/db/sqlalchemy/migrate_repo/versions/156_cidr_column_length.py +++ b/nova/db/sqlalchemy/migrate_repo/versions/156_cidr_column_length.py @@ -40,7 +40,7 @@ def upgrade(migrate_engine): migrate_engine.execute( "ALTER TABLE %(table)s " "ALTER COLUMN %(column)s TYPE INET USING %(column)s::INET" - % locals()) + % {'table': table, 'column': column}) else: for table, column in CIDR_TABLE_COLUMNS: t = Table(table, meta, autoload=True) -- cgit