From abd8957650641338e473db61cfb12f738a0d5d09 Mon Sep 17 00:00:00 2001 From: Robert Collins Date: Tue, 22 Jan 2013 11:07:22 +1300 Subject: Generate coverage even if tests failed. A test failing doesn't make coverage useless, so we should always generate it. Change-Id: I3ed9e54213c7fb6756906553920d19c5075e1adb --- run_tests.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/run_tests.sh b/run_tests.sh index 39176d78b..6c04abb5a 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -95,6 +95,13 @@ function run_tests { copy_subunit_log + if [ $coverage -eq 1 ]; then + echo "Generating coverage report in covhtml/" + # Don't compute coverage for common code, which is tested elsewhere + ${wrapper} coverage combine + ${wrapper} coverage html --include='nova/*' --omit='nova/openstack/common/*' -d covhtml -i + fi + return $RESULT } @@ -197,10 +204,3 @@ if [ -z "$testrargs" ]; then run_pep8 fi fi - -if [ $coverage -eq 1 ]; then - echo "Generating coverage report in covhtml/" - # Don't compute coverage for common code, which is tested elsewhere - ${wrapper} coverage combine - ${wrapper} coverage html --include='nova/*' --omit='nova/openstack/common/*' -d covhtml -i -fi -- cgit