From 107b15d2dd7d554d9cca177343ab45c51029d484 Mon Sep 17 00:00:00 2001
From: Mark Washenberger <mark.washenberger@rackspace.com>
Date: Fri, 27 May 2011 10:15:33 -0400
Subject: fix encryption handling of newlines again and restructure the code a
 bit

---
 nova/tests/test_xenapi.py | 22 ++++++++++++++++++----
 nova/virt/xenapi/vmops.py | 24 +++++++-----------------
 2 files changed, 25 insertions(+), 21 deletions(-)

diff --git a/nova/tests/test_xenapi.py b/nova/tests/test_xenapi.py
index 3ba37a762..0632d05a5 100644
--- a/nova/tests/test_xenapi.py
+++ b/nova/tests/test_xenapi.py
@@ -592,12 +592,26 @@ class XenAPIDiffieHellmanTestCase(test.TestCase):
         bob_shared = self.bob.compute_shared(alice_pub)
         self.assertEquals(alice_shared, bob_shared)
 
-    def test_encryption(self):
-        msg = "This is a top-secret message"
-        enc = self.alice.encrypt(msg)
+    def _test_encryption(self, message):
+        enc = self.alice.encrypt(message)
         self.assertFalse(enc.endswith('\n'))
         dec = self.bob.decrypt(enc)
-        self.assertEquals(dec, msg)
+        self.assertEquals(dec, message)
+
+    def test_encrypt_simple_message(self):
+        self._test_encryption('This is a simple message.')
+
+    def test_encrypt_message_with_newlines_at_end(self):
+        self._test_encryption('This message has a newline at the end.\n')
+
+    def test_encrypt_many_newlines_at_end(self):
+        self._test_encryption('Message with lotsa newlines.\n\n\n')
+
+    def test_encrypt_newlines_inside_message(self):
+        self._test_encryption('Message\nwith\ninterior\nnewlines.')
+
+    def test_encrypt_with_leading_newlines(self):
+        self._test_encryption('\n\nMessage with leading newlines.')
 
     def tearDown(self):
         super(XenAPIDiffieHellmanTestCase, self).tearDown()
diff --git a/nova/virt/xenapi/vmops.py b/nova/virt/xenapi/vmops.py
index 1d8678ce2..ce84c8652 100644
--- a/nova/virt/xenapi/vmops.py
+++ b/nova/virt/xenapi/vmops.py
@@ -1190,30 +1190,20 @@ class SimpleDH(object):
         mpi = M2Crypto.m2.bn_to_mpi(bn)
         return mpi
 
-    def _run_ssl(self, text, which):
-        base_cmd = ('openssl enc -aes-128-cbc -a -pass pass:%(shared)s '
-                '-nosalt %(dec_flag)s')
-        if which.lower()[0] == 'd':
-            dec_flag = ' -d'
-            # When decoding base64, we need to make sure there's a
-            # single '\n' at the end of the base64 encoded data.
-            # It's kinda dumb that openssl wants to see a newline
-            text = text.strip('\n') + '\n'
-        else:
-            dec_flag = ''
-        shared = self._shared
-        cmd = base_cmd % locals()
-        proc = _runproc(cmd)
+    def _run_ssl(self, subcommand, text):
+        proc = _runproc('openssl %s' % subcommand)
         proc.stdin.write(text)
         proc.stdin.close()
         proc.wait()
         err = proc.stderr.read()
         if err:
             raise RuntimeError(_('OpenSSL error: %s') % err)
-        return proc.stdout.read().strip('\n')
+        return proc.stdout.read()
 
     def encrypt(self, text):
-        return self._run_ssl(text, 'enc')
+        cmd = 'enc -aes-128-cbc -a -pass pass:%s -nosalt' % self._shared
+        return self._run_ssl(cmd, text).strip('\n')
 
     def decrypt(self, text):
-        return self._run_ssl(text, 'dec')
+        cmd = 'enc -aes-128-cbc -a -A -pass pass:%s -nosalt -d' % self._shared
+        return self._run_ssl(cmd, text)
-- 
cgit 


From f6d847cd867c09319f9fc451c09dc7322542e26b Mon Sep 17 00:00:00 2001
From: Mark Washenberger <mark.washenberger@rackspace.com>
Date: Fri, 27 May 2011 10:40:50 -0400
Subject: prevent encryption from adding newlines on long messages

---
 nova/tests/test_xenapi.py | 4 ++++
 nova/virt/xenapi/vmops.py | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/nova/tests/test_xenapi.py b/nova/tests/test_xenapi.py
index 0632d05a5..fe37f0ebe 100644
--- a/nova/tests/test_xenapi.py
+++ b/nova/tests/test_xenapi.py
@@ -594,6 +594,7 @@ class XenAPIDiffieHellmanTestCase(test.TestCase):
 
     def _test_encryption(self, message):
         enc = self.alice.encrypt(message)
+        print enc
         self.assertFalse(enc.endswith('\n'))
         dec = self.bob.decrypt(enc)
         self.assertEquals(dec, message)
@@ -613,6 +614,9 @@ class XenAPIDiffieHellmanTestCase(test.TestCase):
     def test_encrypt_with_leading_newlines(self):
         self._test_encryption('\n\nMessage with leading newlines.')
 
+    def test_encrypt_really_long_message(self):
+        self._test_encryption(''.join(['abcd' for i in xrange(1024)]))
+
     def tearDown(self):
         super(XenAPIDiffieHellmanTestCase, self).tearDown()
 
diff --git a/nova/virt/xenapi/vmops.py b/nova/virt/xenapi/vmops.py
index ce84c8652..1fcaaeede 100644
--- a/nova/virt/xenapi/vmops.py
+++ b/nova/virt/xenapi/vmops.py
@@ -1201,7 +1201,7 @@ class SimpleDH(object):
         return proc.stdout.read()
 
     def encrypt(self, text):
-        cmd = 'enc -aes-128-cbc -a -pass pass:%s -nosalt' % self._shared
+        cmd = 'enc -aes-128-cbc -a -A -pass pass:%s -nosalt' % self._shared
         return self._run_ssl(cmd, text).strip('\n')
 
     def decrypt(self, text):
-- 
cgit 


From 60a291747eeded09ade608088eae47fdb300a56b Mon Sep 17 00:00:00 2001
From: Mark Washenberger <mark.washenberger@rackspace.com>
Date: Fri, 27 May 2011 10:41:12 -0400
Subject: remove errant print statement

---
 nova/tests/test_xenapi.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/nova/tests/test_xenapi.py b/nova/tests/test_xenapi.py
index fe37f0ebe..9d56c1644 100644
--- a/nova/tests/test_xenapi.py
+++ b/nova/tests/test_xenapi.py
@@ -594,7 +594,6 @@ class XenAPIDiffieHellmanTestCase(test.TestCase):
 
     def _test_encryption(self, message):
         enc = self.alice.encrypt(message)
-        print enc
         self.assertFalse(enc.endswith('\n'))
         dec = self.bob.decrypt(enc)
         self.assertEquals(dec, message)
-- 
cgit