From 55175f5cd91e8b5c87805c65cbbd89cc12c66752 Mon Sep 17 00:00:00 2001 From: Boris Filippov Date: Wed, 15 Aug 2012 04:45:36 +0400 Subject: Remove assigned, but unused variables from nova/db/sqlalchemy/api.py model_query already create session if it's not supplied in kwargs. So there was no point in creating session and even not passing it to model_query. Also, nobody even cares about 'specs' in volume_type_create. Change-Id: Ic60dca9bbfcf908fa50a43424e7d93319b2f210b --- nova/db/sqlalchemy/api.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/nova/db/sqlalchemy/api.py b/nova/db/sqlalchemy/api.py index 63947cdb3..94468bf7e 100644 --- a/nova/db/sqlalchemy/api.py +++ b/nova/db/sqlalchemy/api.py @@ -729,7 +729,6 @@ def floating_ip_get(context, id): @require_context def floating_ip_get_pools(context): - session = get_session() pools = [] for result in model_query(context, models.FloatingIp.pool).distinct(): pools.append({'name': result[0]}) @@ -4493,8 +4492,6 @@ def volume_type_create(context, values): except exception.VolumeTypeNotFoundByName: pass try: - specs = values.get('extra_specs') - values['extra_specs'] = _metadata_refs(values.get('extra_specs'), models.VolumeTypeExtraSpecs) volume_type_ref = models.VolumeTypes() @@ -4763,7 +4760,6 @@ def sm_backend_conf_get(context, sm_backend_id): @require_admin_context def sm_backend_conf_get_by_sr(context, sr_uuid): - session = get_session() result = model_query(context, models.SMBackendConf, read_deleted="yes").\ filter_by(sr_uuid=sr_uuid).\ first() -- cgit