summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | | | | | Distinguish rootwrap Authorization vs Not found errorsPádraig Brady2012-03-062-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rootwrap will return "not authorized" for a command that is defined in the rootwrap filters but not installed on the system. Therefore return the first matching filter for such a command so that sudo will try to execute it and return a more appropriate error. Change-Id: I77eeff229e73d55083a735af7a9029469132c800
* | | | | | | | | | | | | | | Merge "Update fixed_ip_associate to not use relationships"Jenkins2012-03-072-8/+44
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Update fixed_ip_associate to not use relationshipsMaru Newby2012-03-042-8/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * fixed_ip_associate was using the FixedIp.instance and FixedIp.network relationships, which were removed. This change updates the method to use instance_id and network_id instead. * Adds unit tests for fixed_ip_associate * Resolves bug 943029 Change-Id: I0829d110058b8799a520ab68b5fa1b2370b9cc3e
* | | | | | | | | | | | | | | Merge "Bug #943178: aggregate extension lacks documentation"Jenkins2012-03-072-0/+187
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Bug #943178: aggregate extension lacks documentationArmando Migliaccio2012-03-062-0/+187
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add rst docs for this extension. Change-Id: I74080c240a0a6911271674177ac08a113b4c50d1
* | | | | | | | | | | | | | | Merge "Finally fix the docs venv bug."Jenkins2012-03-062-0/+646
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | Finally fix the docs venv bug.Monty Taylor2012-03-052-0/+646
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes bug 902846. Turns out that without providing a default css file, docutils tries to pull one in from a location using very bad path logic. Glance was providing the css file explicitly and it worked, so I just copied them. Change-Id: I6cc9d0ca148149637104c27f6c020030bdbcfe18
* | | | | | | | | | | | | | | | Merge "Shorten FLAGS.rpc_response_timeout"Jenkins2012-03-061-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | Shorten FLAGS.rpc_response_timeoutAnthony Young2012-03-061-1/+1
| | |_|_|_|/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixes bug 938287 * Bump timeout to 60 seconds Change-Id: I0f38fe0bdfc950386f1fce221069e395e7e81f2a
* | | | | | | | | | | | | | | | Merge "Only pass image uuids to compute api rebuild"Jenkins2012-03-062-9/+61
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|/ / / / / / / |/| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Only pass image uuids to compute api rebuildMark Washenberger2012-03-062-9/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses bug 881641 Change-Id: I9c0270d5ceb126387a0052c83937ae778d1f49cb
* | | | | | | | | | | | | | | | Merge "Ensure image status filter matches glance format"Jenkins2012-03-062-4/+9
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / / / / / / |/| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Ensure image status filter matches glance formatBrian Waldon2012-03-012-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixes bug 943259 Change-Id: Id5172aa40be2f5a337b3e192b4bee8139c16c4d3
* | | | | | | | | | | | | | | | Merge "Better glance exception handling"Jenkins2012-03-065-21/+124
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / / / / / / / / |/| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Better glance exception handlingMark Washenberger2012-03-065-21/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Adds a conversion step that turns glance exceptions into nova exceptions - Converts Invalid to HTTPBadRequest in /images and /images/detail, fixing bug 944846 - Makes stub glance client return glance exceptions instead of nova exceptions - Rebased off of http://review.openstack.org/4788 to pick up MissingCredentialError handling as well, and added a test - A few small, miscellaneous testing fixes for issues I noticed Change-Id: I88eebfe7a7ac21cc5cd84ad84d64b311ddccf91e
* | | | | | | | | | | | | | | | Merge "Rename files/dirs from 'rabbit' to 'rpc'."Jenkins2012-03-0611-6/+6
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | Rename files/dirs from 'rabbit' to 'rpc'.Russell Bryant2012-03-0611-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that the rpc API includes more than RabbitMQ, update a filename and directory name to be 'rpc' instead of 'rabbit'. Change-Id: Ib7fcccdd77fae128b6de3ee490fee3d6325ca7c5
* | | | | | | | | | | | | | | | | Merge "Change references to RabbitMQ to include Qpid."Jenkins2012-03-062-22/+22
|\| | | | | | | | | | | | | | | | | |_|_|_|_|_|_|_|_|/ / / / / / / |/| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Change references to RabbitMQ to include Qpid.Russell Bryant2012-03-062-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the documentation that referred to RabbitMQ to clarify that Qpid can be used, as well. Change-Id: I3abe32c2074bfdd3b5129ea65e9ca36cc9555c27
* | | | | | | | | | | | | | | | Merge "Check all migrations have downgrade in test_misc"Jenkins2012-03-061-24/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | Check all migrations have downgrade in test_miscHengqing Hu2012-02-281-24/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug #942406 Change-Id: Ifbc74c12a4c58d4e2117295c088051062a0b3b1c
* | | | | | | | | | | | | | | | | Merge "Rename DistributedScheduler as FilterScheduler"Jenkins2012-03-066-23/+23
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | Rename DistributedScheduler as FilterSchedulerJoe Gordon2012-03-056-23/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I1091609d5997c4ba9c26a3f2426496ff7f1e64fa
* | | | | | | | | | | | | | | | | | Merge "Fixes for ec2 images"Jenkins2012-03-065-7/+73
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|/ / / / / / / / / / / / / / | |/| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | Fixes for ec2 imagesVishvananda Ishaya2012-03-025-7/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixes s3 image service to convert back to uuids on update * Adds exception for attempt to update an unowned image * Adds error messages to ec2 for failure cases * Adds tests to verify changes * Fixes bug 942865 Change-Id: I35331c635756f10c02b30dd43ab3fe0ad98bc28c
* | | | | | | | | | | | | | | | | | Merge "Ensures that we don't exceed iptables chain max"Jenkins2012-03-061-1/+5
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | Ensures that we don't exceed iptables chain maxVishvananda Ishaya2012-03-021-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixes bug 944184 Change-Id: Ifb25f253ab32c9895aae276e946058eb62e14957
* | | | | | | | | | | | | | | | | | | Merge "Fixes bug 942556 and bug 944105"Jenkins2012-03-062-47/+55
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | | Fixes bug 942556 and bug 944105John Garbutt2012-03-022-47/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensures the calls in the xenhost plugin work when the host is in a xenserver pool managed by the host aggregates feature. Change-Id: I51ca6b9f6d0e8d86d53afde5bf46cfabde17a44e
* | | | | | | | | | | | | | | | | | | | Merge "Test creating a server with metadata key too long."Jenkins2012-03-061-0/+30
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | | | Test creating a server with metadata key too long.Russell Bryant2012-03-011-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Related to bug 917484. This bug reported that the OpenStack API returned the wrong type of error when creating an instance with a metadata key that was too long. I added this unit test to try it out and it appears to work as expected, so might as well just keep the test around. Change-Id: Ie4bcf81741a268fd8319e1ecaad5639ad8c9b6f7
* | | | | | | | | | | | | | | | | | | | | Merge "Fixing incorrect use of instance keyword in logging."Jenkins2012-03-061-4/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | | | | Fixing incorrect use of instance keyword in logging.Alex Meade2012-03-061-4/+4
| | |_|_|_|_|_|/ / / / / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug 948154 Change-Id: I8adc48482c26528d1e671c8e038c23caaa0f861d
* | | | | | | | | | | | | | | | | | | | | Merge "Provide a provider for boto.utils"Jenkins2012-03-061-0/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | | | | Provide a provider for boto.utilsHengqing Hu2012-03-061-0/+2
| | |_|_|_|_|_|_|_|/ / / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug #945355 Change-Id: I0b09f6d8d2373f52359806945de467585421fb65
* | | | | | | | | | | | | | | | | | | | | Merge "Get rid of all of the autodoc import errors."Jenkins2012-03-063-8/+6
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|_|/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | | | Get rid of all of the autodoc import errors.Monty Taylor2012-03-053-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This hasn't worked right in a bazillion years. Change-Id: I4db20ce97f920cdb7254d51e18a0630b0283b39d
* | | | | | | | | | | | | | | | | | | | | Merge "Decode nova-manage args into unicode."Jenkins2012-03-061-0/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | | | | Decode nova-manage args into unicode.Andrew Bogott2012-02-261-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This improves handling of non-ASCII args... it's not exactly a comprehensive solution, though. Partial (demonstration) fix for bug 931667. Change-Id: Icc2aabe9c0c521732003f7013438630ebc8d2238
* | | | | | | | | | | | | | | | | | | | | | Merge "No longer ignoring man/novamanage"Jenkins2012-03-061-1/+0
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | | | | | No longer ignoring man/novamanageDerek Higgins2012-03-061-1/+0
| | |_|_|/ / / / / / / / / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes Bug #948165 man/novamanage is a manpage and should be included Change-Id: I497b3d2a348dc74f8ebcd08e628a6b9324dd3a8f
* | | | | | | | | | | | | | | | | | | | | | Merge "sm volume driver: fix backend adding failure"Jenkins2012-03-061-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|_|_|_|/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | | | | sm volume driver: fix backend adding failureRenuka Apte2012-02-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug 915085 Change-Id: I908d2090815a90bae479d5caf8516e52fd879c8e
* | | | | | | | | | | | | | | | | | | | | | Merge "Nova options tool enhancements"Jenkins2012-03-062-21/+11
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|_|_|/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | | | | Nova options tool enhancementsZhongyue Luo2012-02-242-21/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug #936898 1. Just import the modules and only look at nova.flags.FLAGS when they're all imported 2. ConfigOpts is iterable, there should be no need to iterate the private FLAGS._opts dict 3. Output should be .ini style 4. The output should only contain comments i.e. each option default should be commented out Change-Id: I15835bb437bc6d575e8311d7c55b3a29d67b006d
* | | | | | | | | | | | | | | | | | | | | | Avoid running code that uses logging in a threadJohannes Erdfelt2012-03-061-0/+7
| |_|/ / / / / / / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug 946687 This avoids problems with code that uses logging from running in a thread which isn't necessary for unit tests anyway. Change-Id: I9c296c3c46317c9aaba7f1a92cd565a35682ce23
* | | | | | | | | | | | | | | | | | | | | Fix rst formatting and cross-referencesDoug Hellmann2012-03-0631-328/+339
| |_|_|_|/ / / / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | blueprint sphinx-doc-cleanup bug 944385 - Fix formatting and markup issues that produce error messages - Update TOC lists for missing/new files - Fix a few links - Update instructions with dependencies for building the documentation - Updated base on review comments from oubiwann to fix trailing whitespace in modified files Change-Id: I589152bfab9c543d2b11fa8bed2344259aa90675
* | | | | | | | | | | | | | | | | | | | Merge "Allows new style config to be used for --flagfile"Jenkins2012-03-062-2/+11
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | | Allows new style config to be used for --flagfileVishvananda Ishaya2012-03-052-2/+11
| | |_|_|_|_|_|_|/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * includes tests * fixes bug 947549 Change-Id: Ibf319ea75a2d6156c5d8f1112cd58a33e5a98fe0
* | | | | | | | | | | | | | | | | | | Merge "Raise 409 when rescuing instance in RESCUE mode"Jenkins2012-03-063-1/+25
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | | | |