| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |_|_|_|_|/ /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This should be the second last blueprint finish-uuid-conversion change.
Change-Id: Idd47c5ed3c30af24d60eb23b8e3881d61b4c7976
|
| |\ \ \ \ \ \ \ \ |
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Fixes bug 1029627
Change-Id: I8b137cafe56be5f2f9ffca08c0edc1d1468bc3b1
|
| |\ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
The checks_instance_lock decorator currently discards any return value
from the functions it wraps. Luckily, none of the callers of these
functions check for a return value.
Since the return values are unused, just remove them. Fixing the
decorator to return them would effectively be a change to the RPC
API.
And since we know the return value is unused, we also know that nothing
checks for the False return from checks_instance_lock() and that too
can be removed.
Change-Id: I8b49107dba51caf52665341e4977de179b6404f6
|
| |\ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Currently, the real reason for a failure is dropped when attempting
to unroll the volume connection (with the exception of when it is
VIR_ERR_OPERATION_FAILED). This change uses save_and_reraise_exception()
to correct that so that the actual reason for failure gets logged.
Fixes bug 1029463
Change-Id: Id47db565c4fb5a88d1a263600b41706dd3419726
|
| |\ \ \ \ \ \ \ \ \ \ \
| |_|_|/ / / / / / / /
|/| | | | | | | | | | |
|
| | | |_|/ / / / / / /
| |/| | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Fixes nova-volume aspect of LP 1027281.
Use view builder pattern to only include non-extraneous
volume type attributes in the representation.
Change-Id: I33f1b579fd6ed4ed98fa04e9148e91eca125213e
|
| |\ \ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
The 'is' operator compares identity, not value. Python doesn't guarantee
that two strings that are the same will also be the same object.
Change-Id: I2d7e7947b14272fa2a82d5e8eefa95dcaba375f7
|
| |\ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / /
|/| | | | | | | | | | |
|
| | | |_|_|_|_|_|/ / /
| |/| | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
The check used 'is' when it should have been '=='.
Also, a couple of small cleanups to make the code easier to read.
Change-Id: If98892703bc557732093230b023085c4744b8455
|
| |\ \ \ \ \ \ \ \ \ \ |
|
| | |/ / / / / / / / /
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Certain errors that can occur while booting an instance may leave no
VM on the Xen hypervisor. This can make that instance undeletable,
since the first step in soft_delete() is to power_off the instance,
and nothing catches the NotFound error thrown if the instance doesn't
exist. The libvirt support handles the case of a non-existant
instance by ignoring NotFound--after all, a non-existant instance is,
by definition, powered off, right?
Fixes bug 1029132.
Change-Id: I5bffe3b61fe92fc32fb70cab941fa5ecd250df77
|
| |\ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / /
|/| | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Fixes bug 1029397
This adds better retry support, making sure that if we need to retry
requests to glance, we cycle through all hosts before potentially
attemping the hosts that failed. The old random selection could cause
immediate retrying of the same host that failed.
This also adds logging of the host:port that failed and fixes a bug in
the retry test, which didn't actually successfully test retrying.
Tests for new code added.
Change-Id: I400616081e1e547b9ca2e0be622889d3a399a5bf
|
| |\ \ \ \ \ \ \ \ \ \ |
|
| | |/ / / / / / / / /
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Updates the virt/disk/api so that we no longer import libvirt_utils.
This fixes issues when using Nova compute with compute drivers other
than libvirt. (xenapi, etc.)
Fixes LP Bug #1029501.
Change-Id: I46ece309480ce0a0941a96371a51d77712c41eb6
|
| |\ \ \ \ \ \ \ \ \ \
| | |_|_|/ / / / / /
| |/| | | | | | | | |
|
| | | |/ / / / / / /
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Commit eebc64f removed some error logging, presumably by mistake.
If checks_instance_state fails, and the action blocked, users aren't
notified but the error is logged for admins. Changing this behavior
clearly wasn't the intent of the no-db-messaging commit.
Change-Id: I14581171c201770b03cecc77d4a2933c9687ef11
|
| |\ \ \ \ \ \ \ \ \
| |_|/ / / / / / /
|/| | | | | | | | |
|
| | | |_|/ / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fixes bug 888229
Change-Id: I38779cbc84c5eacd796ce1ae5559d1ebffd1037e
|
| |\ \ \ \ \ \ \ \ |
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
The default value for weight of the compute_fill_first_cost_fn is
actually -1.0, which means it does exactly the opposite of what
the function docstring says it does. Update the docstring to
warn people of this fact.
Issue reported via bug #1023827 which was closed as won't fix
but the docs should be clearer. Updated based on feedback.
Change-Id: I56acde254c932a8e66f941aaeb7304665500610f
|
| |\ \ \ \ \ \ \ \ \
| |_|/ / / / / / /
|/| | | | | | | | |
|
| | | |_|_|_|_|_|/
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Add pick_disk_driver_name to utils, to be able to set driver_name
consistently across volume and imagebackend. This is mostly required for
xen.
Xen requires specifying both the driver name and type attributes when
defining disks. E.g. the following disk XML snippet
<disk type='file' device='disk'>
<driver type='qcow2'/>
<source file='/tmp/disk0.qcow2'/>
<target dev='xvda'/>
</disk>
produces incorrect configuration in the xen tools
(uname file:/tmp/disk0.qcow2)
Including the driver name fixes this
<disk type='file' device='disk'>
<driver name='tap' type='qcow2'/>
<source file='/tmp/disk0.qcow2'/>
<target dev='xvda'/>
</disk>
produces
(uname tap:qcow2:/tmp/disk0.qcow2)
Change-Id: Id984e0c431b6fc743a39e6e6f3dc3eb289fbb43a
|
| |\ \ \ \ \ \ \ \ |
|
| | | |_|/ / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
The check_output method does not exist in python 2.6
Fixes bug 1029014
Change-Id: I1ee24fa2029f21706924cc19dfcbc41655b022e6
|
| |\ \ \ \ \ \ \ \
| |_|_|_|/ / / /
|/| | | | | | | |
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
* nova/virt/images.py: Define a single function that
calls `qemu-img info` in a robust manner, by avoiding
locale issues etc.
* nova/virt/libvirt/utils.py: Define secondary functions
to parse items returned from images.qemu_img_info().
* nova/virt/libvirt/driver.py: Use the libvirt.utils functions.
* nova/virt/disk/api.py: Likewise.
* nova/tests/test_libvirt.py: Remove no longer needed stub
for utils.execute('qemu-img info'). Adjust to a more restrictive
`qemu-img info` format, and more robust calling signature.
* nova/tests/test_imagebackend.py: Adjust to moved method.
Change-Id: I739dd246410c215f401ebd3a92b8207f46e8fb9a
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
* changes:
Send a full instance via rpc for detach_volume.
Send a full instance via rpc for confirm_resize.
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change the detach_volume method of the compute rpc API to take
a full instance over rpc instead of just the instance UUID.
This cuts down on database access needed by nova-compute.
Part of blueprint no-db-messaging.
Change-Id: Ibc5e4f16c393bf97fcc4fe9b76e6b435eb99de87
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change the confirm_resize method of the compute rpc API to take
a full instance over rpc instead of just the instance UUID.
This cuts down on database access needed by nova-compute.
Part of blueprint no-db-messaging.
Change-Id: I58313564b240c6b55de1849efc2d5d9031a1c97c
|
| |\| | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
* changes:
Remove unused methods from compute rpcapi.
Send a full instance via rpc for check_can_live_migrate_source.
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Remove some deprecated methods from the compute rpcapi. These methods
remain in the compute manager code, but there is no need to have them
here in the client side code since they aren't used and we don't want
any new code trying to use them.
Change-Id: I0ae2cd3f25339d91fbd27f8a157b3f95e2acbc6f
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change the check_can_live_migrate_source method of the compute
rpc API to take a full instance over rpc instead of just the instance
UUID. This cuts down on database access needed by nova-compute.
Part of blueprint no-db-messaging.
Change-Id: Ifc655fb86c94adc9a64e878a89a77342313cace2
|
| | |_|/ / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Address a couple of recently introduced PEP8 violations in
console output API extension.
Change-Id: Ia80fa5103e342c8e51772b0edc2a115abeaddf36
|
| |\ \ \ \ \ \ \ \ |
|
| | | |_|_|/ / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This is a sanity check to ensure the footer timestamps on a VHD are
reasonable (e.g. not in the future). This condition can occur if the
local time for the source and destination machines in a migration are
not in agreement, requiring an adjustment to /etc/localtime and/or NTP
reconfiguration.
Without this check there is a risk of importing a corrupt VHD into the
SR causing the entire SR to become corrupted.
Change-Id: I17228e50d6f54632f3bfc32a682e511f876517ec
|
| |\ \ \ \ \ \ \ \
| |_|_|_|_|_|/ /
|/| | | | | | | |
|
| | | |_|_|/ / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This stress-test runs builds and migrations concurrently making it
easier to uncovers certain types of race-conditions in the virt-layer
code.
Change-Id: I89c382b85aa6d0eb3dc957803f3ea34e3a36e9d4
|
| |\ \ \ \ \ \ \ |
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Updates a log messages in the Nova cinderclient function so
it doesn't log the auth token from the request context.
Also properly localizes the log message.
Fixes LP Bug #1029049.
Change-Id: I89120f0e9b7a33c00b9b4b629d61d44d0e9b518f
|
| |\ \ \ \ \ \ \ \ |
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
* The same functionality exists in the filter scheduler, except for
nova volumes. So just keep nova-volume scheduling here.
* Add very basic Simple Scheduler testing
* Simple Scheduler will be completely removed after Folsom release
Change-Id: Ia2a2b26bc67cf152963533d68a774f454d763cbd
|
| |\ \ \ \ \ \ \ \ \
| | |_|_|_|/ / / /
| |/| | | | | | | |
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change the check_can_live_migrate_destination method of the compute
rpc API to take a full instance over rpc instead of just the instance
UUID. This cuts down on database access needed by nova-compute.
Part of blueprint no-db-messaging.
Change-Id: I98a403fc4af7c3660c5144e532a318151c6c3b54
|
| |\ \ \ \ \ \ \ \ \ |
|
| | | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Fix for bug 1029206.
Change-Id: I61550f22a063ada0dfc654f8f653dcf52637f191
|