summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--nova/tests/api/ec2/test_cinder_cloud.py5
-rw-r--r--nova/tests/network/test_manager.py20
2 files changed, 7 insertions, 18 deletions
diff --git a/nova/tests/api/ec2/test_cinder_cloud.py b/nova/tests/api/ec2/test_cinder_cloud.py
index d403ba1f0..5e5723a08 100644
--- a/nova/tests/api/ec2/test_cinder_cloud.py
+++ b/nova/tests/api/ec2/test_cinder_cloud.py
@@ -18,9 +18,10 @@
# under the License.
import copy
-import tempfile
import uuid
+import fixtures
+
from nova.api.ec2 import cloud
from nova.api.ec2 import ec2utils
from nova.compute import api as compute_api
@@ -86,7 +87,7 @@ def get_instances_with_cached_ips(orig_func, *args, **kwargs):
class CinderCloudTestCase(test.TestCase):
def setUp(self):
super(CinderCloudTestCase, self).setUp()
- vol_tmpdir = tempfile.mkdtemp()
+ vol_tmpdir = self.useFixture(fixtures.TempDir()).path
self.flags(compute_driver='nova.virt.fake.FakeDriver',
volume_api_class='nova.tests.fake_volume.API')
diff --git a/nova/tests/network/test_manager.py b/nova/tests/network/test_manager.py
index 1552630fb..b5b3ec107 100644
--- a/nova/tests/network/test_manager.py
+++ b/nova/tests/network/test_manager.py
@@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
import shutil
-import tempfile
+import fixtures
import mox
from nova import context
@@ -142,7 +142,7 @@ vifs = [{'id': 0,
class FlatNetworkTestCase(test.TestCase):
def setUp(self):
super(FlatNetworkTestCase, self).setUp()
- self.tempdir = tempfile.mkdtemp()
+ self.tempdir = self.useFixture(fixtures.TempDir()).path
self.flags(log_dir=self.tempdir)
self.network = network_manager.FlatManager(host=HOST)
self.network.instance_dns_domain = ''
@@ -150,10 +150,6 @@ class FlatNetworkTestCase(test.TestCase):
self.context = context.RequestContext('testuser', 'testproject',
is_admin=False)
- def tearDown(self):
- shutil.rmtree(self.tempdir)
- super(FlatNetworkTestCase, self).tearDown()
-
def test_get_instance_nw_info(self):
fake_get_instance_nw_info = fake_network.fake_get_instance_nw_info
@@ -1629,7 +1625,7 @@ class FloatingIPTestCase(test.TestCase):
"""Tests nova.network.manager.FloatingIP."""
def setUp(self):
super(FloatingIPTestCase, self).setUp()
- self.tempdir = tempfile.mkdtemp()
+ self.tempdir = self.useFixture(fixtures.TempDir()).path
self.flags(log_dir=self.tempdir)
self.network = TestFloatingIPManager()
self.network.db = db
@@ -1637,10 +1633,6 @@ class FloatingIPTestCase(test.TestCase):
self.context = context.RequestContext('testuser', self.project_id,
is_admin=False)
- def tearDown(self):
- shutil.rmtree(self.tempdir)
- super(FloatingIPTestCase, self).tearDown()
-
def test_disassociate_floating_ip_multi_host_calls(self):
floating_ip = {
'fixed_ip_id': 12
@@ -2128,7 +2120,7 @@ class InstanceDNSTestCase(test.TestCase):
"""Tests nova.network.manager instance DNS."""
def setUp(self):
super(InstanceDNSTestCase, self).setUp()
- self.tempdir = tempfile.mkdtemp()
+ self.tempdir = self.useFixture(fixtures.TempDir()).path
self.flags(log_dir=self.tempdir)
self.network = TestFloatingIPManager()
self.network.db = db
@@ -2136,10 +2128,6 @@ class InstanceDNSTestCase(test.TestCase):
self.context = context.RequestContext('testuser', self.project_id,
is_admin=False)
- def tearDown(self):
- shutil.rmtree(self.tempdir)
- super(InstanceDNSTestCase, self).tearDown()
-
def test_dns_domains_private(self):
zone1 = 'testzone'
domain1 = 'example.org'