diff options
| author | Jenkins <jenkins@review.openstack.org> | 2012-08-09 05:52:11 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2012-08-09 05:52:11 +0000 |
| commit | 408d3e3dc1600471d1198e72e123c4e308ecc1f4 (patch) | |
| tree | 6952d122ad7e4a2be60eddf1f647e1033db83b44 /tools/hacking.py | |
| parent | 600a3bd10d00252d13e8d35502c53db693e7253d (diff) | |
| parent | 47a1bbe3114c4e5bb84c5b050ecc9baff83375cc (diff) | |
Merge "Add a 50 char git title limit test to hacking."
Diffstat (limited to 'tools/hacking.py')
| -rwxr-xr-x | tools/hacking.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/hacking.py b/tools/hacking.py index edb06525e..4eb2141f7 100755 --- a/tools/hacking.py +++ b/tools/hacking.py @@ -431,6 +431,7 @@ def once_git_check_commit_title(): nova HACKING recommends not referencing a bug or blueprint in first line, it should provide an accurate description of the change N801 + N802 Title limited to 50 chars """ #Get title of most recent commit @@ -453,6 +454,9 @@ def once_git_check_commit_title(): print ("N801: git commit title ('%s') should provide an accurate " "description of the change, not just a reference to a bug " "or blueprint" % title.strip()) + if len(title.decode('utf-8')) > 72: + print ("N802: git commit title ('%s') should be under 50 chars" + % title.strip()) if __name__ == "__main__": #include nova path |
