diff options
| author | Russell Bryant <rbryant@redhat.com> | 2013-03-05 10:55:18 -0500 |
|---|---|---|
| committer | Russell Bryant <rbryant@redhat.com> | 2013-03-05 10:57:55 -0500 |
| commit | 2f983793574de07269c4a79852d75a9059465ee0 (patch) | |
| tree | b3c007c3f5fc8d45e4e575a6d233e19bcdeffe92 /nova/wsgi.py | |
| parent | ad57a303f1916d99f73eb8123f60c8a2fd1e6a78 (diff) | |
| download | nova-2f983793574de07269c4a79852d75a9059465ee0.tar.gz nova-2f983793574de07269c4a79852d75a9059465ee0.tar.xz nova-2f983793574de07269c4a79852d75a9059465ee0.zip | |
Fix issues with re-raising exceptions.
There is complication with re-raising exceptions and our usage of
eventlet. If the code in the exception handler accesses the db or rpc
in the exception handler, it will no longer be able to re-raise the
exception. Using excutils.save_and_reraise_exception() works aorund
this issue.
The most common error is calling LOG.error() or LOG.exception(), as it
is possible for these to go access rpc. There is an option to turn on
notifications for these errors.
Fix bug 845866.
Change-Id: Icfca2af63805711229249aa7abe60a938edd1b35
Diffstat (limited to 'nova/wsgi.py')
| -rw-r--r-- | nova/wsgi.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/nova/wsgi.py b/nova/wsgi.py index b9e204b90..72e464919 100644 --- a/nova/wsgi.py +++ b/nova/wsgi.py @@ -34,6 +34,7 @@ import webob.dec import webob.exc from nova import exception +from nova.openstack.common import excutils from nova.openstack.common import log as logging wsgi_opts = [ @@ -175,9 +176,9 @@ class Server(object): CONF.tcp_keepidle) except Exception: - LOG.error(_("Failed to start %(name)s on %(host)s" - ":%(port)s with SSL support") % self.__dict__) - raise + with excutils.save_and_reraise_exception(): + LOG.error(_("Failed to start %(name)s on %(host)s" + ":%(port)s with SSL support") % self.__dict__) wsgi_kwargs = { 'func': eventlet.wsgi.server, |