summaryrefslogtreecommitdiffstats
path: root/nova/virt
diff options
context:
space:
mode:
authorEldar Nugaev <enugaev@griddynamics.com>2011-04-03 03:45:33 +0400
committerEldar Nugaev <enugaev@griddynamics.com>2011-04-03 03:45:33 +0400
commita8d186d212ffbc628fc2b2672eca1e0557c57414 (patch)
tree3839ac1330d7ca947101fb4be3417e57d64e925b /nova/virt
parent78cebece92abc63490595178caa6aaf09fab1545 (diff)
split up to_xml to creation xml_info and filling the template
Diffstat (limited to 'nova/virt')
-rw-r--r--nova/virt/libvirt_conn.py12
1 files changed, 7 insertions, 5 deletions
diff --git a/nova/virt/libvirt_conn.py b/nova/virt/libvirt_conn.py
index f34ea7225..910d8a634 100644
--- a/nova/virt/libvirt_conn.py
+++ b/nova/virt/libvirt_conn.py
@@ -936,7 +936,7 @@ class LibvirtConnection(driver.ComputeDriver):
return result
- def to_xml(self, instance, rescue=False, network_info=None):
+ def _prepare_xml_info(self, instance, rescue=False, network_info=None):
# TODO(termie): cache?
LOG.debug(_('instance %s: starting toXML method'), instance['name'])
@@ -947,8 +947,7 @@ class LibvirtConnection(driver.ComputeDriver):
nics = []
for (network, mapping) in network_info:
- nics.append(self._get_nic_for_xml(network,
- mapping))
+ nics.append(self._get_nic_for_xml(network, mapping))
# FIXME(vish): stick this in db
instance_type_name = instance['instance_type']
instance_type = instance_types.get_instance_type(instance_type_name)
@@ -979,10 +978,13 @@ class LibvirtConnection(driver.ComputeDriver):
xml_info['ramdisk'] = xml_info['basepath'] + "/ramdisk"
xml_info['disk'] = xml_info['basepath'] + "/disk"
+
+ return xml_info
+ def to_xml(self, instance, rescue=False, network_info=None):
+ xml_info = self._prepare_xml_info(instance, rescue, network_info)
xml = str(Template(self.libvirt_xml, searchList=[xml_info]))
- LOG.debug(_('instance %s: finished toXML method'),
- instance['name'])
+ LOG.debug(_('instance %s: finished toXML method'), instance['name'])
return xml
def get_info(self, instance_name):