diff options
| author | Russell Bryant <rbryant@redhat.com> | 2012-07-27 12:21:08 -0400 |
|---|---|---|
| committer | Russell Bryant <rbryant@redhat.com> | 2012-07-30 20:18:38 -0400 |
| commit | 73af6fa9722b720923002f62e115d84b74c9fe33 (patch) | |
| tree | 6707baabf79a2c5f5fb980ce84c47db52e44f65e /nova/tests | |
| parent | 100528f3a0df724c5a9611f0e7a0cce41ca5e12e (diff) | |
Send a full instance in remove_volume_connection.
Change the remove_volume_connection method of the compute
rpc API to take a full instance over rpc instead of just
the instance ID. This cuts down on database access needed
by nova-compute.
Part of blueprint no-db-messaging.
Change-Id: I1bd47b161acd7b6dfb03adb77d00a861f754e188
Diffstat (limited to 'nova/tests')
| -rw-r--r-- | nova/tests/compute/test_compute.py | 6 | ||||
| -rw-r--r-- | nova/tests/compute/test_rpcapi.py | 8 |
2 files changed, 8 insertions, 6 deletions
diff --git a/nova/tests/compute/test_compute.py b/nova/tests/compute/test_compute.py index fc2b183d9..27f0eb565 100644 --- a/nova/tests/compute/test_compute.py +++ b/nova/tests/compute/test_compute.py @@ -1612,11 +1612,13 @@ class ComputeTestCase(BaseTestCase): 'args': {'instance_id': inst_id, 'host': self.compute.host, 'teardown': False}}) + rpcinst = jsonutils.to_primitive( + db.instance_get_by_uuid(self.context, instance['uuid'])) rpc.call(c, topic, {"method": "remove_volume_connection", - "args": {'instance_id': inst_id, + "args": {'instance': rpcinst, 'volume_id': volume_id}, - "version": "1.0"}, None) + "version": "1.26"}, None) rpc.cast(c, topic, {"method": "rollback_live_migration_at_destination", "args": {'instance_id': inst_id}, diff --git a/nova/tests/compute/test_rpcapi.py b/nova/tests/compute/test_rpcapi.py index e081c1455..edfbc309b 100644 --- a/nova/tests/compute/test_rpcapi.py +++ b/nova/tests/compute/test_rpcapi.py @@ -58,7 +58,7 @@ class ComputeRpcAPITestCase(test.TestCase): 'post_live_migration_at_destination', 'power_off_instance', 'power_on_instance', 'pre_live_migration', 'reboot_instance', 'rebuild_instance', 'remove_fixed_ip_from_instance', - 'start_instance', 'stop_instance', + 'remove_volume_connection', 'start_instance', 'stop_instance', 'suspend_instance', 'unpause_instance' ] @@ -84,8 +84,7 @@ class ComputeRpcAPITestCase(test.TestCase): methods_with_instance): instance = expected_msg['args']['instance'] del expected_msg['args']['instance'] - if method in ['rollback_live_migration_at_destination', - 'remove_volume_connection']: + if method in ['rollback_live_migration_at_destination']: expected_msg['args']['instance_id'] = instance['id'] else: expected_msg['args']['instance_uuid'] = instance['uuid'] @@ -262,7 +261,8 @@ class ComputeRpcAPITestCase(test.TestCase): def test_remove_volume_connection(self): self._test_compute_api('remove_volume_connection', 'call', - instance=self.fake_instance, volume_id='id', host='host') + instance=self.fake_instance, volume_id='id', host='host', + version='1.26') def test_rescue_instance(self): self._test_compute_api('rescue_instance', 'cast', |