summaryrefslogtreecommitdiffstats
path: root/nova/rootwrap
diff options
context:
space:
mode:
authorThierry Carrez <thierry@openstack.org>2013-01-17 11:36:22 +0100
committerThierry Carrez <thierry@openstack.org>2013-01-17 13:32:30 +0100
commit476f15d610b84a7a5fe97a88f46dea38dc409794 (patch)
tree40300cedd0b7a78d21e171f0d7876b57f48a6fca /nova/rootwrap
parentd806266d2367535f19f542a0716cadf6c64d243b (diff)
Use common rootwrap from oslo-incubator
Make Nova use common rootwrap code from oslo-incubator. Implements bp nova-common-rootwrap Change-Id: I3282d65940375589fceb8485829097380d84d946
Diffstat (limited to 'nova/rootwrap')
-rw-r--r--nova/rootwrap/__init__.py16
-rw-r--r--nova/rootwrap/filters.py180
-rw-r--r--nova/rootwrap/wrapper.py149
3 files changed, 0 insertions, 345 deletions
diff --git a/nova/rootwrap/__init__.py b/nova/rootwrap/__init__.py
deleted file mode 100644
index 671d3c173..000000000
--- a/nova/rootwrap/__init__.py
+++ /dev/null
@@ -1,16 +0,0 @@
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright (c) 2011 OpenStack, LLC.
-# All Rights Reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License"); you may
-# not use this file except in compliance with the License. You may obtain
-# a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
diff --git a/nova/rootwrap/filters.py b/nova/rootwrap/filters.py
deleted file mode 100644
index 8958f1ba1..000000000
--- a/nova/rootwrap/filters.py
+++ /dev/null
@@ -1,180 +0,0 @@
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright (c) 2011 OpenStack, LLC.
-# All Rights Reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License"); you may
-# not use this file except in compliance with the License. You may obtain
-# a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
-
-import os
-import re
-
-
-class CommandFilter(object):
- """Command filter only checking that the 1st argument matches exec_path."""
-
- def __init__(self, exec_path, run_as, *args):
- self.name = ''
- self.exec_path = exec_path
- self.run_as = run_as
- self.args = args
- self.real_exec = None
-
- def get_exec(self, exec_dirs=[]):
- """Returns existing executable, or empty string if none found."""
- if self.real_exec is not None:
- return self.real_exec
- self.real_exec = ""
- if self.exec_path.startswith('/'):
- if os.access(self.exec_path, os.X_OK):
- self.real_exec = self.exec_path
- else:
- for binary_path in exec_dirs:
- expanded_path = os.path.join(binary_path, self.exec_path)
- if os.access(expanded_path, os.X_OK):
- self.real_exec = expanded_path
- break
- return self.real_exec
-
- def match(self, userargs):
- """Only check that the first argument (command) matches exec_path."""
- if (os.path.basename(self.exec_path) == userargs[0]):
- return True
- return False
-
- def get_command(self, userargs, exec_dirs=[]):
- """Returns command to execute (with sudo -u if run_as != root)."""
- to_exec = self.get_exec(exec_dirs=exec_dirs) or self.exec_path
- if (self.run_as != 'root'):
- # Used to run commands at lesser privileges
- return ['sudo', '-u', self.run_as, to_exec] + userargs[1:]
- return [to_exec] + userargs[1:]
-
- def get_environment(self, userargs):
- """Returns specific environment to set, None if none."""
- return None
-
-
-class RegExpFilter(CommandFilter):
- """Command filter doing regexp matching for every argument."""
-
- def match(self, userargs):
- # Early skip if command or number of args don't match
- if (len(self.args) != len(userargs)):
- # DENY: argument numbers don't match
- return False
- # Compare each arg (anchoring pattern explicitly at end of string)
- for (pattern, arg) in zip(self.args, userargs):
- try:
- if not re.match(pattern + '$', arg):
- break
- except re.error:
- # DENY: Badly-formed filter
- return False
- else:
- # ALLOW: All arguments matched
- return True
-
- # DENY: Some arguments did not match
- return False
-
-
-class DnsmasqFilter(CommandFilter):
- """Specific filter for the dnsmasq call (which includes env)."""
-
- CONFIG_FILE_ARG = 'CONFIG_FILE'
-
- def match(self, userargs):
- if (userargs[0] == 'env' and
- userargs[1].startswith(self.CONFIG_FILE_ARG) and
- userargs[2].startswith('NETWORK_ID=') and
- userargs[3] == 'dnsmasq'):
- return True
- return False
-
- def get_command(self, userargs, exec_dirs=[]):
- to_exec = self.get_exec(exec_dirs=exec_dirs) or self.exec_path
- dnsmasq_pos = userargs.index('dnsmasq')
- return [to_exec] + userargs[dnsmasq_pos + 1:]
-
- def get_environment(self, userargs):
- env = os.environ.copy()
- env[self.CONFIG_FILE_ARG] = userargs[1].split('=')[-1]
- env['NETWORK_ID'] = userargs[2].split('=')[-1]
- return env
-
-
-class DeprecatedDnsmasqFilter(DnsmasqFilter):
- """Variant of dnsmasq filter to support old-style FLAGFILE."""
- CONFIG_FILE_ARG = 'FLAGFILE'
-
-
-class KillFilter(CommandFilter):
- """Specific filter for the kill calls.
- 1st argument is the user to run /bin/kill under
- 2nd argument is the location of the affected executable
- Subsequent arguments list the accepted signals (if any)
-
- This filter relies on /proc to accurately determine affected
- executable, so it will only work on procfs-capable systems (not OSX).
- """
-
- def __init__(self, *args):
- super(KillFilter, self).__init__("/bin/kill", *args)
-
- def match(self, userargs):
- if userargs[0] != "kill":
- return False
- args = list(userargs)
- if len(args) == 3:
- # A specific signal is requested
- signal = args.pop(1)
- if signal not in self.args[1:]:
- # Requested signal not in accepted list
- return False
- else:
- if len(args) != 2:
- # Incorrect number of arguments
- return False
- if len(self.args) > 1:
- # No signal requested, but filter requires specific signal
- return False
- try:
- command = os.readlink("/proc/%d/exe" % int(args[1]))
- # NOTE(dprince): /proc/PID/exe may have ' (deleted)' on
- # the end if an executable is updated or deleted
- if command.endswith(" (deleted)"):
- command = command[:command.rindex(" ")]
- if command != self.args[0]:
- # Affected executable does not match
- return False
- except (ValueError, OSError):
- # Incorrect PID
- return False
- return True
-
-
-class ReadFileFilter(CommandFilter):
- """Specific filter for the utils.read_file_as_root call."""
-
- def __init__(self, file_path, *args):
- self.file_path = file_path
- super(ReadFileFilter, self).__init__("/bin/cat", "root", *args)
-
- def match(self, userargs):
- if userargs[0] != 'cat':
- return False
- if userargs[1] != self.file_path:
- return False
- if len(userargs) != 2:
- return False
- return True
diff --git a/nova/rootwrap/wrapper.py b/nova/rootwrap/wrapper.py
deleted file mode 100644
index 70bd63c47..000000000
--- a/nova/rootwrap/wrapper.py
+++ /dev/null
@@ -1,149 +0,0 @@
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright (c) 2011 OpenStack, LLC.
-# All Rights Reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License"); you may
-# not use this file except in compliance with the License. You may obtain
-# a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
-
-
-import ConfigParser
-import logging
-import logging.handlers
-import os
-import string
-
-from nova.rootwrap import filters
-
-
-class NoFilterMatched(Exception):
- """This exception is raised when no filter matched."""
- pass
-
-
-class FilterMatchNotExecutable(Exception):
- """
- This exception is raised when a filter matched but no executable was
- found.
- """
- def __init__(self, match=None, **kwargs):
- self.match = match
-
-
-class RootwrapConfig(object):
-
- def __init__(self, config):
- # filters_path
- self.filters_path = config.get("DEFAULT", "filters_path").split(",")
-
- # exec_dirs
- if config.has_option("DEFAULT", "exec_dirs"):
- self.exec_dirs = config.get("DEFAULT", "exec_dirs").split(",")
- else:
- # Use system PATH if exec_dirs is not specified
- self.exec_dirs = os.environ["PATH"].split(':')
-
- # syslog_log_facility
- if config.has_option("DEFAULT", "syslog_log_facility"):
- v = config.get("DEFAULT", "syslog_log_facility")
- facility_names = logging.handlers.SysLogHandler.facility_names
- self.syslog_log_facility = getattr(logging.handlers.SysLogHandler,
- v, None)
- if self.syslog_log_facility is None and v in facility_names:
- self.syslog_log_facility = facility_names.get(v)
- if self.syslog_log_facility is None:
- raise ValueError('Unexpected syslog_log_facility: %s' % v)
- else:
- default_facility = logging.handlers.SysLogHandler.LOG_SYSLOG
- self.syslog_log_facility = default_facility
-
- # syslog_log_level
- if config.has_option("DEFAULT", "syslog_log_level"):
- v = config.get("DEFAULT", "syslog_log_level")
- self.syslog_log_level = logging.getLevelName(v.upper())
- if (self.syslog_log_level == "Level %s" % v.upper()):
- raise ValueError('Unexepected syslog_log_level: %s' % v)
- else:
- self.syslog_log_level = logging.ERROR
-
- # use_syslog
- if config.has_option("DEFAULT", "use_syslog"):
- self.use_syslog = config.getboolean("DEFAULT", "use_syslog")
- else:
- self.use_syslog = False
-
-
-def setup_syslog(execname, facility, level):
- rootwrap_logger = logging.getLogger()
- rootwrap_logger.setLevel(level)
- handler = logging.handlers.SysLogHandler(address='/dev/log',
- facility=facility)
- handler.setFormatter(logging.Formatter(
- os.path.basename(execname) + ': %(message)s'))
- rootwrap_logger.addHandler(handler)
-
-
-def build_filter(class_name, *args):
- """Returns a filter object of class class_name."""
- if not hasattr(filters, class_name):
- logging.warning("Skipping unknown filter class (%s) specified "
- "in filter definitions" % class_name)
- return None
- filterclass = getattr(filters, class_name)
- return filterclass(*args)
-
-
-def load_filters(filters_path):
- """Load filters from a list of directories."""
- filterlist = []
- for filterdir in filters_path:
- if not os.path.isdir(filterdir):
- continue
- for filterfile in os.listdir(filterdir):
- filterconfig = ConfigParser.RawConfigParser()
- filterconfig.read(os.path.join(filterdir, filterfile))
- for (name, value) in filterconfig.items("Filters"):
- filterdefinition = [string.strip(s) for s in value.split(',')]
- newfilter = build_filter(*filterdefinition)
- if newfilter is None:
- continue
- newfilter.name = name
- filterlist.append(newfilter)
- return filterlist
-
-
-def match_filter(filters, userargs, exec_dirs=[]):
- """
- Checks user command and arguments through command filters and
- returns the first matching filter.
- Raises NoFilterMatched if no filter matched.
- Raises FilterMatchNotExecutable if no executable was found for the
- best filter match.
- """
- first_not_executable_filter = None
-
- for f in filters:
- if f.match(userargs):
- # Try other filters if executable is absent
- if not f.get_exec(exec_dirs=exec_dirs):
- if not first_not_executable_filter:
- first_not_executable_filter = f
- continue
- # Otherwise return matching filter for execution
- return f
-
- if first_not_executable_filter:
- # A filter matched, but no executable was found for it
- raise FilterMatchNotExecutable(match=first_not_executable_filter)
-
- # No filter matched
- raise NoFilterMatched()