diff options
| author | Mark McLoughlin <markmc@redhat.com> | 2012-08-29 09:21:03 +0100 |
|---|---|---|
| committer | Mark McLoughlin <markmc@redhat.com> | 2012-08-29 12:06:36 +0100 |
| commit | 8cf635b08a57a9e3be2bef980ef38cf857b6525a (patch) | |
| tree | db4eb0485f03c6445db8e61274022dc43da26b50 /nova/openstack | |
| parent | 6727b259af491177514f075a3db91d55810c66e4 (diff) | |
| download | nova-8cf635b08a57a9e3be2bef980ef38cf857b6525a.tar.gz nova-8cf635b08a57a9e3be2bef980ef38cf857b6525a.tar.xz nova-8cf635b08a57a9e3be2bef980ef38cf857b6525a.zip | |
Stop using scheduler RPC API magic
If a scheduler RPC message isn't handled directly by a SchedulerManager
method, the __getattr__() fallback passes the message to a driver
method in the form of schedule_${method}() and, if that doesn't exist,
instead calls the schedule() method supplying the topic and method
args.
This is pretty bizarre stuff and we appear to only use it in two cases:
1) live_migration - this is how the schedule_live_migration()
method in the driver gets called, but the side-effect is that
we require the client to pass a topic argument which is never
used. This would be much more sanely handled with an explicit
SchedulerManager.live_migration() method.
2) create_volume - the volume API asks the scheduler to pick a
target host for create_volume() using this method. This would
be easily handled with an SchedulerManager.create_volume()
method.
Change-Id: I1047489d85ac51d8d36fea1c4eb858df638ce349
Diffstat (limited to 'nova/openstack')
0 files changed, 0 insertions, 0 deletions
