diff options
| author | David Ripton <dripton@redhat.com> | 2013-04-02 12:19:17 -0400 |
|---|---|---|
| committer | David Ripton <dripton@redhat.com> | 2013-04-02 14:51:16 -0400 |
| commit | 34de8d1529fb9a2e7fad096a6967b9a483ab0cb0 (patch) | |
| tree | 173d8bf13f92de851bfe221fc718564b73dc5268 /nova/openstack | |
| parent | 0ae8a9a7e7b0dce76b3530b99ce881da8285a0ce (diff) | |
| download | nova-34de8d1529fb9a2e7fad096a6967b9a483ab0cb0.tar.gz nova-34de8d1529fb9a2e7fad096a6967b9a483ab0cb0.tar.xz nova-34de8d1529fb9a2e7fad096a6967b9a483ab0cb0.zip | |
Raise rather than generating millions of IPs.
Fixes bug #1163394
Formerly if we tried to create many millions of floating IPs with a
range like "192.168.2.224/2", address_to_hosts would happily iterate
over all of them (which would take a long time) and then nova-manage
would eventually crash with an OutOfMemoryError when we tried putting
all of them in a list. Or, if the initial list wasn't quite big
enough to use all memory, it would blow up later (even more slowly)
when we tried to put them in the database via SQLAlchemy.
Now, raise exception.InvalidInput if the number of IPs is a million
or more. (A million is erring on the side of caution.)
Change-Id: Ifc6b6a8faadc2e97e09f9f6c975e52229f705789
Diffstat (limited to 'nova/openstack')
0 files changed, 0 insertions, 0 deletions