diff options
| author | Mark McLoughlin <markmc@redhat.com> | 2012-12-05 23:05:59 +0000 |
|---|---|---|
| committer | Mark McLoughlin <markmc@redhat.com> | 2012-12-05 23:05:59 +0000 |
| commit | 2a33f8d8cefdbde50f89e6d4084d513eadf3a97a (patch) | |
| tree | a3b9b4143da9e1e8768d8aab5fbb0c316beed599 /nova/openstack | |
| parent | 255692feea3eee12bfc763f75fc8f3dabdbe9ba5 (diff) | |
| download | nova-2a33f8d8cefdbde50f89e6d4084d513eadf3a97a.tar.gz nova-2a33f8d8cefdbde50f89e6d4084d513eadf3a97a.tar.xz nova-2a33f8d8cefdbde50f89e6d4084d513eadf3a97a.zip | |
Fix positional arg swallow decorator
The update() method in the hosts extension is decorated with @check_host
but the function returned by decorator takes a kwarg which shadows the
'body' positional arg of the update() method.
i.e. if you call:
controller.update(req, id, body)
then the body arg gets passed to the wrapper as its service kwarg and
never passed through to update(). We can see how the tests are all
passing body as a kwarg to avoid this.
Remove the service arg from check_host() but also from _list_hosts()
since the only place it is used is in the tests.
Change-Id: I12aab582c15c25fd35ecda005341291450c7efdc
Diffstat (limited to 'nova/openstack')
0 files changed, 0 insertions, 0 deletions
