summaryrefslogtreecommitdiffstats
path: root/nova/console
diff options
context:
space:
mode:
authorMonsyne Dragon <mdragon@rackspace.com>2011-01-05 22:11:05 -0600
committerMonsyne Dragon <mdragon@rackspace.com>2011-01-05 22:11:05 -0600
commitb55940e8e3d977960ff60f4cb7cff4b6ea2e8fb8 (patch)
tree1115bf6dc7b6376a13fd4d68f1ebce7d9028ec71 /nova/console
parentf9fa25f9a873c1e4831c342689f7b5adc8f41013 (diff)
downloadnova-b55940e8e3d977960ff60f4cb7cff4b6ea2e8fb8.tar.gz
nova-b55940e8e3d977960ff60f4cb7cff4b6ea2e8fb8.tar.xz
nova-b55940e8e3d977960ff60f4cb7cff4b6ea2e8fb8.zip
fix some glitches due to someone removing instanc.internal_id (not that I mind)
remove accidental change to nova-combined script
Diffstat (limited to 'nova/console')
-rw-r--r--nova/console/api.py23
-rw-r--r--nova/console/driver.py2
2 files changed, 11 insertions, 14 deletions
diff --git a/nova/console/api.py b/nova/console/api.py
index 54317e3b3..93e28ad64 100644
--- a/nova/console/api.py
+++ b/nova/console/api.py
@@ -36,20 +36,16 @@ class ConsoleAPI(base.Base):
def __init__(self, **kwargs):
super(ConsoleAPI, self).__init__(**kwargs)
- def get_consoles(self, context, instance_internal_id):
- instance = self.db.instance_get_by_internal_id(context,
- instance_internal_id)
- return self.db.console_get_all_by_instance(context, instance['id'])
+ def get_consoles(self, context, instance_id):
+ return self.db.console_get_all_by_instance(context, instance_id)
- def get_console(self, context, instance_internal_id, console_id):
- return self.db.console_get(context, console_id, instance_internal_id)
+ def get_console(self, context, instance_id, console_id):
+ return self.db.console_get(context, console_id, instance_id)
- def delete_console(self, context, instance_internal_id, console_id):
- instance = self.db.instance_get_by_internal_id(context,
- instance_internal_id)
+ def delete_console(self, context, instance_id, console_id):
console = self.db.console_get(context,
console_id,
- instance['id'])
+ instance_id)
pool = console['pool']
rpc.cast(context,
self.db.queue_get_for(context,
@@ -58,9 +54,8 @@ class ConsoleAPI(base.Base):
{"method": "remove_console",
"args": {"console_id": console['id']}})
- def create_console(self, context, instance_internal_id):
- instance = self.db.instance_get_by_internal_id(context,
- instance_internal_id)
+ def create_console(self, context, instance_id):
+ instance = self.db.instance_get(context, instance_id)
#NOTE(mdragon): If we wanted to return this the console info
# here, as we would need to do a call.
# They can just do an index later to fetch
@@ -69,7 +64,7 @@ class ConsoleAPI(base.Base):
rpc.cast(context,
self._get_console_topic(context, instance['host']),
{"method": "add_console",
- "args": {"instance_id": instance['id']}})
+ "args": {"instance_id": instance_id}})
def _get_console_topic(self, context, instance_host):
topic = self.db.queue_get_for(context,
diff --git a/nova/console/driver.py b/nova/console/driver.py
index d2dafb1f3..c4cf5e5e9 100644
--- a/nova/console/driver.py
+++ b/nova/console/driver.py
@@ -19,6 +19,8 @@
ConsoleProxy base class that all ConsoleProxies should inherit from
"""
+import os
+
from nova import exception