diff options
| author | Rongze Zhu <zrzhit@gmail.com> | 2012-09-12 09:18:53 +0000 |
|---|---|---|
| committer | Rongze Zhu <zrzhit@gmail.com> | 2012-09-13 05:19:55 +0000 |
| commit | cce5cf45f738ed95a96a4526253bec01a15277f0 (patch) | |
| tree | 5aab122f9f70071a4f9857bc16a713b884643671 /nova/api | |
| parent | e72db9fe9345c48f4ea287643306d884c82f04f4 (diff) | |
| download | nova-cce5cf45f738ed95a96a4526253bec01a15277f0.tar.gz nova-cce5cf45f738ed95a96a4526253bec01a15277f0.tar.xz nova-cce5cf45f738ed95a96a4526253bec01a15277f0.zip | |
Return 400 if create volume snapshot force parameter is invalid
Fixes bug #1014689
* Add is_valid_boolstr function in utils.py
* Add force parameter check in SnapshotsController.create()
* Add unittest for invalid force parameter.
Change-Id: Ie6a07a2ac589da76f52a82b126a6d66e5987edc4
Diffstat (limited to 'nova/api')
| -rw-r--r-- | nova/api/openstack/compute/contrib/volumes.py | 7 | ||||
| -rw-r--r-- | nova/api/openstack/volume/snapshots.py | 7 |
2 files changed, 12 insertions, 2 deletions
diff --git a/nova/api/openstack/compute/contrib/volumes.py b/nova/api/openstack/compute/contrib/volumes.py index 41e168411..7194f64e3 100644 --- a/nova/api/openstack/compute/contrib/volumes.py +++ b/nova/api/openstack/compute/contrib/volumes.py @@ -27,6 +27,7 @@ from nova import compute from nova import exception from nova import flags from nova.openstack.common import log as logging +from nova import utils from nova import volume from nova.volume import volume_types @@ -595,7 +596,11 @@ class SnapshotController(object): LOG.audit(_("Create snapshot from volume %s"), volume_id, context=context) - if force: + if not utils.is_valid_boolstr(force): + msg = _("Invalid value '%s' for force. ") % force + raise exception.InvalidParameterValue(err=msg) + + if utils.bool_from_str(force): new_snapshot = self.volume_api.create_snapshot_force(context, volume, snapshot.get('display_name'), diff --git a/nova/api/openstack/volume/snapshots.py b/nova/api/openstack/volume/snapshots.py index 91823de79..755398369 100644 --- a/nova/api/openstack/volume/snapshots.py +++ b/nova/api/openstack/volume/snapshots.py @@ -24,6 +24,7 @@ from nova.api.openstack import xmlutil from nova import exception from nova import flags from nova.openstack.common import log as logging +from nova import utils from nova import volume @@ -154,7 +155,11 @@ class SnapshotsController(object): msg = _("Create snapshot from volume %s") LOG.audit(msg, volume_id, context=context) - if force: + if not utils.is_valid_boolstr(force): + msg = _("Invalid value '%s' for force. ") % force + raise exception.InvalidParameterValue(err=msg) + + if utils.bool_from_str(force): new_snapshot = self.volume_api.create_snapshot_force(context, volume, snapshot.get('display_name'), |