summaryrefslogtreecommitdiffstats
path: root/nova/api
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2013-03-25 23:07:26 +0000
committerGerrit Code Review <review@openstack.org>2013-03-25 23:07:26 +0000
commitba5669cc438dbb6b03f2b2b7a6e35e09b2a23396 (patch)
tree6905fa6930a49f0efe37418391be0177f72483ae /nova/api
parente61cbe5819343d3f69fff2efa1807bf7bf7fa2ad (diff)
parent7ab98e935a63454d0736e6f8a7525a8e73cf6c04 (diff)
downloadnova-ba5669cc438dbb6b03f2b2b7a6e35e09b2a23396.tar.gz
nova-ba5669cc438dbb6b03f2b2b7a6e35e09b2a23396.tar.xz
nova-ba5669cc438dbb6b03f2b2b7a6e35e09b2a23396.zip
Merge "Remove unnecessary DB call to find EC2 AZs."
Diffstat (limited to 'nova/api')
-rw-r--r--nova/api/ec2/cloud.py3
-rw-r--r--nova/api/ec2/ec2utils.py8
-rw-r--r--nova/api/metadata/base.py4
3 files changed, 5 insertions, 10 deletions
diff --git a/nova/api/ec2/cloud.py b/nova/api/ec2/cloud.py
index 206a72679..0d06dde33 100644
--- a/nova/api/ec2/cloud.py
+++ b/nova/api/ec2/cloud.py
@@ -1188,8 +1188,7 @@ class CloudController(object):
self._format_instance_bdm(context, instance['uuid'],
i['rootDeviceName'], i)
host = instance['host']
- services = db.service_get_all_by_host(context.elevated(), host)
- zone = ec2utils.get_availability_zone_by_host(services, host)
+ zone = ec2utils.get_availability_zone_by_host(host)
i['placement'] = {'availabilityZone': zone}
if instance['reservation_id'] not in reservations:
r = {}
diff --git a/nova/api/ec2/ec2utils.py b/nova/api/ec2/ec2utils.py
index a9aa70900..1f4b8d6ee 100644
--- a/nova/api/ec2/ec2utils.py
+++ b/nova/api/ec2/ec2utils.py
@@ -137,11 +137,9 @@ def get_ip_info_for_instance(context, instance):
return get_ip_info_for_instance_from_nw_info(nw_info)
-def get_availability_zone_by_host(services, host, conductor_api=None):
- if len(services) > 0:
- return availability_zones.get_host_availability_zone(
- context.get_admin_context(), host, conductor_api)
- return 'unknown zone'
+def get_availability_zone_by_host(host, conductor_api=None):
+ return availability_zones.get_host_availability_zone(
+ context.get_admin_context(), host, conductor_api)
def id_to_ec2_id(instance_id, template='i-%08x'):
diff --git a/nova/api/metadata/base.py b/nova/api/metadata/base.py
index 896c8fbd7..90dcb9ca5 100644
--- a/nova/api/metadata/base.py
+++ b/nova/api/metadata/base.py
@@ -106,10 +106,8 @@ class InstanceMetadata():
ctxt = context.get_admin_context()
capi = self.conductor_api
- services = capi.service_get_all_by_host(ctxt.elevated(),
- instance['host'])
self.availability_zone = ec2utils.get_availability_zone_by_host(
- services, instance['host'], capi)
+ instance['host'], capi)
self.ip_info = ec2utils.get_ip_info_for_instance(ctxt, instance)